Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-restrict the XMLUtils class after SECURITY-521 release #4032

Merged
merged 2 commits into from May 22, 2019

Conversation

@Wadeck
Copy link
Contributor

commented May 17, 2019

  • It was forgotten since that actually

See SECURITY-521 resolved in Feb 2018.

Proposed changelog entries

  • Internal: Un-restrict the XMLUtils class that was added during a previous security release

Submitter checklist

  • [n/a] JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • [n/a] Appropriate autotests or explanation to why this change has no tests
  • [n/a] For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@jtnord @MRamonLeon @daniel-beck

Un-restrict the XMLUtils class after SECURITY-521 release
- It was forgotten since that actually
@jtnord

jtnord approved these changes May 17, 2019

Update core/src/main/java/jenkins/util/xml/XMLUtils.java
Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
@oleg-nenashev
Copy link
Member

left a comment

Will merge it towards the next weekly if no negative feedback

@jvz

jvz approved these changes May 20, 2019

@oleg-nenashev oleg-nenashev merged commit 1f290ff into jenkinsci:master May 22, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
@@ -37,9 +35,9 @@
import javax.xml.xpath.XPathFactory;

/**
* Utilities useful when working with various XML types.
* Utilities useful when working with various XML types.
* @since 1.596.1 and 1.600, unrestricted since TODO

This comment has been minimized.

Copy link
@jglick

jglick May 24, 2019

Member

@since need only mention the version in which it was unrestricted. If anyone cares for some reason about versions in which it was present but restricted (why?), they can use Git history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.