Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-25369] Add Javadoc to new class #4037

Merged
merged 1 commit into from May 21, 2019

Conversation

4 participants
@fcojfernandez
Copy link
Contributor

commented May 20, 2019

See JENKINS-25369.

This PR is a follow up of #4021. It adds the javadoc for the new class JenkinsJmDNS

Proposed changelog entries

  • Internal: Add the javadoc for the new class JenkinsJmDNS

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@oleg-nenashev @batmat

@oleg-nenashev
Copy link
Member

left a comment

Just one minor comment

* The abort() method is pretty similar to close() method. To access private methods and fields uses
* reflection.
*
* @since 2.178

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev May 20, 2019

Member

Not needed for private classes

This comment has been minimized.

Copy link
@fcojfernandez

fcojfernandez May 20, 2019

Author Contributor

I know the @since annotation is not needed for private classes, but in this case I've added because we are deprecating the jenkinsci fork of jmdns and I think it could be interesting to keep the trace of when that happened just with a glance. I would be happy to remove it tough

@batmat

batmat approved these changes May 20, 2019

Copy link
Member

left a comment

LGTM.

I believe we don't really need a changelog BTW.

@batmat batmat merged commit d464ce7 into jenkinsci:master May 21, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@fcojfernandez fcojfernandez deleted the fcojfernandez:JENKINS-25369 branch Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.