Fix invalid condition in toEmailSafeString

[Egor18]

Condition 'z'<=ch && ch<='Z' is always false. See http://www.asciitable.com/

[oleg-nenashev]

@Egor18 is it a defect which impacts your instance? If so, could you please raise a JIRA ticket?

[oleg-nenashev]

Will merge tomorrow if no negative feedback

[Wadeck]

which impacts your instance?

@oleg-nenashev I do not want to reply in place of @Egor18 but he's using a tool to detect those flows.

This one is particularly interesting because it's only used in the core.
The method is Hudson#getJobCaseInsensitive which try to find project name A that is similar to B. Before doing the comparison, it applies the method toEmailSafeString on both sides and then compare. Meaning it's "just" too lenient and will not hide positive result, just display potentially some "negative" results. Correcting the behavior will provide more accurate results.

I looked at the plugin ecosystem, nobody is using that public static method (search in GH and local checkout plugins)

Anyway, thank you very much for your interest in the project @Egor18 it's really appreciated 👍

[Egor18]

Yeah, I found this while testing my data-flow analyzer on your source code, so I thought it would be nice to report some bugs :)
So this defect did not affect me directly.

[oleg-nenashev]

Retriggering CI

[oleg-nenashev]

Thanks for your contribution @Egor18 !