Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS 62560] Fixes button transitions #4770

Conversation

fqueiruga
Copy link
Contributor

@fqueiruga fqueiruga commented Jun 4, 2020

See JENKINS-62560.

This PR limits button transitions to color changes. It was causing visual regressions since button changes (2.233). In particular, buttons would linger for a fraction of a second after closing a modal (steps to reproduce on the ticket).

Screenshots Captura de pantalla 2020-06-04 a las 11 36 30 Captura de pantalla 2020-06-04 a las 11 36 41

Proposed changelog entries

  • Fix buttons lingering for a bit after closing modal (regression in 2.233).

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@timja

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested but looks good

@res0nance res0nance added bug For changelog: Minor bug. Will be listed after features web-ui The PR includes WebUI changes which may need special expertise and removed web-ui The PR includes WebUI changes which may need special expertise labels Jun 4, 2020
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may merge it in 24 hours if no negative feedback. Please see the merge process documentation for more information

@oleg-nenashev oleg-nenashev added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback web-ui The PR includes WebUI changes which may need special expertise labels Jun 4, 2020
@oleg-nenashev oleg-nenashev merged commit 0f7de9d into jenkinsci:master Jun 5, 2020
@fqueiruga fqueiruga deleted the jenkins-62560_fix-button-transitions branch June 10, 2020 08:59
olivergondza pushed a commit to olivergondza/jenkins that referenced this pull request Jul 1, 2020
…tton-transitions

[JENKINS 62560] Fixes button transitions

(cherry picked from commit 0f7de9d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
8 participants