Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase contrast of the disabled plugin uninstall button #4917

Merged
merged 1 commit into from Sep 14, 2020

Conversation

benebsiny
Copy link
Contributor

@benebsiny benebsiny commented Aug 24, 2020

See JENKINS-63193.

Proposed changelog entries

  • JENKINS-63193, Increase contrast of the disabled plugin uninstall button on the /pluginManager/installed page

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@daniel-beck daniel-beck added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted skip-changelog Should not be shown in the changelog labels Aug 24, 2020
@daniel-beck
Copy link
Member

@benebsiny Thanks for the PR! Could you provide before/after screenshots?

@benebsiny
Copy link
Contributor Author

Before
image

After
image

@MRamonLeon
Copy link
Contributor

MRamonLeon commented Aug 27, 2020

@benebsiny could you please improve the proposed changelog entry to set this PR as ready for merge. It's not clear what is it about, try to give all the context in the sentence to the user reading the release notes.

Entry 1: Issue, Uninstall plugin button

For example: _Increase the contrast of the Uninstall button of the Plugin Manager.

Thank you!

@daniel-beck
Copy link
Member

could you please improve the proposed changelog entry

@MRamonLeon This PR is labeled skip-changelog, so that would be a waste of time.

@benebsiny
Copy link
Contributor Author

@MRamonLeon I've modified, have a look of it please :)

@res0nance res0nance added the web-ui The PR includes WebUI changes which may need special expertise label Sep 3, 2020
@timja timja added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 12, 2020
@timja
Copy link
Member

timja commented Sep 12, 2020

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@timja timja merged commit 3f39ae4 into jenkinsci:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted skip-changelog Should not be shown in the changelog web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
7 participants