Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-63905] Agent to controller rather than agent to master #4980

Merged
merged 1 commit into from Oct 10, 2020

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Oct 9, 2020

JENKINS-63905 Terminology - Agent to controller, not agent to master

Update the terminology in the agent access control subsystem so that new screenshots can be taken to insert into the jenkins.io page at https://www.jenkins.io/doc/book/managing/security/#agentmaster-access-control or can be integrated into the new page proposed in PR-3353

Tested interactively to confirm that upgrade from Jenkins 2.249.2 worked as expected and that new install also worked as expected.

Proposed changelog entries

  • Use 'Agent to controller' to describe agent access control system rather than 'agent to master'.

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

New screenshots for documentation

Enabling agent to controller access control

agent-to-controller-access-control-enable

Define exceptions for agent to controller access

agent-to-controller-access-control-exceptions

Update the terminology in the agent access control subsystem so that
new screenshots can be taken to insert into the jenkins.io page at
https://www.jenkins.io/doc/book/managing/security/#agentmaster-access-control
Copy link
Contributor

@res0nance res0nance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translations would probably need work.
The overall master -> Controller terminology would likely need an EPIC in jira as well to track all the required efforts but this is a great start

@oleg-nenashev oleg-nenashev added the bug For changelog: Minor bug. Will be listed after features label Oct 9, 2020
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, thanks @MarkEWaite !

We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process

@oleg-nenashev oleg-nenashev added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 9, 2020
@oleg-nenashev oleg-nenashev merged commit 32138a2 into master Oct 10, 2020
@oleg-nenashev oleg-nenashev deleted the fix-agent-to-master-terminology branch October 10, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
5 participants