Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relates to JENKINS-11073 #509

Closed
wants to merge 2 commits into
base: master
from

Conversation

3 participants
@ndeloof
Copy link
Member

ndeloof commented Jun 25, 2012

expose alternative touch() method in FilePath to optionally ignore windows setLastModified failure

@kohsuke

This comment has been minimized.

Copy link
Member

kohsuke commented Jun 30, 2012

Because I think my fix for JENKINS-11251 also fixes JENKINS-11073, I propose we hold off this commit.

If that doesn't fix the problem, I wonder if we should just log the error that the setLastModified fail, instead of exposing this behaviour as a configurable switch. I fail to see how any caller can make intelligent decision about passing the right value, so might just as well all failures to setLastModified on Windows pass through.

@jglick

This comment has been minimized.

Copy link
Member

jglick commented Sep 21, 2012

The description of this pull request does not seem to have anything to do with its contents.

@ndeloof

This comment has been minimized.

Copy link
Member Author

ndeloof commented Sep 21, 2012

indeed, I used my master branch for this and then override and push -f, so this pull request is not valid anymore

@ndeloof ndeloof closed this Sep 21, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.