Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed [JENKINS-15408]: Rotation of slave launch logs on Windows #582

Merged

Conversation

2 participants
@molekamp
Copy link
Contributor

commented Oct 1, 2012

This pull request fixes [JENKINS-15408]. The problem is caused by a bug in ReopenableRotatingFileOutputStream, as is demonstrated by the unit test testRotation() failing (on Windows only). This pull request fixes the issue and thereby the unit test. This also contributes to fixing [JENKINS-12768].

@molekamp

This comment has been minimized.

Copy link
Owner Author

commented on 5694a7a Oct 1, 2012

In Windows, file1.renameTo(file2) only succeeds if file2 does not exist.

@molekamp

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2012

In theory, this pull request solves a problem with log rotation on Windows slaves: when all rotated log files (slave-{nodeName}.log.1 to .log.10) are in use, the next log rotation will fail to move the current log file to log.1, and instead the current log file will be lost. I say in theory, because I have not actually witnessed the problem myself. If anyone can reproduce it, please raise a Jira so I can link this pull request to it. Otherwise, I will probably just merge this pull request in a couple of days.

Any ideas on whether this merits an update of the change log?

@jglick

This comment has been minimized.

Copy link
Member

commented Oct 3, 2012

All nontrivial changes should be listed in changelog.html.

@molekamp

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2012

I have now reproduced the problem. It is slightly different than I first suspected: the log file effected is the slave launch log file, which is written by the master. Consequently, this problem occurs not for Windows slaves, but for Windows masters running slaves on any platform. I created a Jira ticket and updated the title and description of this pull request.

How does the process around changelog.html work? Should I add a change to that file to this pull request, or is this file updated upon/after merge of the pull request?

@jglick

This comment has been minimized.

Copy link
Member

commented Oct 4, 2012

Unfortunately changelog.html updates are manual. There is a section at the top for trunk changes.

molekamp added a commit that referenced this pull request Nov 17, 2012

Merge pull request #582 from molekamp/ReopenableRotatingFileOutputStr…
…eam-windows

fixed [JENKINS-15408]: Rotation of slave launch logs on Windows

@molekamp molekamp merged commit e655333 into jenkinsci:master Nov 17, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.