Ensure links in help files open in new windows #6095
Merged
+58
−43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's annoying when links in HTML help files that get shown inline after clicking "❔" are not opening in a new window: The current form may have modifications we want to keep.
Rather than fix every plugin ever, this PR changes hudson-behavior to rewrite the inlined HTML to ensure all links open in a new window unless they explicitly already specify the
target
attribute. (It can be set to_self
explicitly to not open in a new window.)Additionally, some cleanup:
_new
isn't a thing (😭), it just behaves similar to_blank
because there's no frame (or popup? It's been a while…) with that name already. In help files, removetarget
entirely and rely on the JS added elsewhere, in HTML shown inline directly on config forms, open in a new window.Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are correctupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).