Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-8614] ProcessTreeTest fails on Windows #752

Merged
merged 3 commits into from Apr 8, 2013

Conversation

3 participants
@lmwang
Copy link
Contributor

lmwang commented Apr 5, 2013

Fixed JENKINS-8614
Add exception handler for getEnvironmentVariables().

@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

cloudbees-pull-request-builder commented Apr 5, 2013

core » jenkins_main_trunk #812 SUCCESS
This pull request looks good

env = new EnvVars(p.getEnvironmentVariables());
} catch (WinpException e)
{
LOGGER.log(FINE, "Failed to get environment variable ", e);

This comment has been minimized.

@jglick

jglick Apr 5, 2013

Member

I think this exception handler needs to call

env = new EnvVars();

so that the method is not returning null. Look at the Javadoc:

empty map if failed (for example because the process is already dead, or the permission was denied.)

@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

cloudbees-pull-request-builder commented Apr 6, 2013

core » jenkins_main_trunk #815 SUCCESS
This pull request looks good

jglick added a commit that referenced this pull request Apr 8, 2013

Merge pull request #752 from lmwang/master
[FIXED JENKINS-8614] ProcessTreeTest fails on Windows

@jglick jglick merged commit 91000fa into jenkinsci:master Apr 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.