Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to the console output from the status icon of an entry in the HistoryWidget. #93

Merged
merged 2 commits into from Apr 28, 2011

Conversation

3 participants
@mfriedenhagen
Copy link
Member

commented Apr 12, 2011

When analyzing failed or unstable builds, having the console output available from the status icon saves one click, which is very convenient if you have a lot of jobs. For sample output see:
http://huschteguzzel.de/hudson/job/sardine/
Note that the status icons of the builds are now links to the console.
When digging through 30 broken builds in the morning (not that bad as we have about 1200 jobs), the console link has helped a lot and was the only feature some developers were missing when we ditched our homegrown version against unpatched jenkins.

@dty

This comment has been minimized.

Copy link
Member

commented Apr 12, 2011

My only comment is one about expectation. If I click on the build number, I would expect to wind up at the summary for that build, not the console. Maybe changing the status icon to be a link would be better?

@mfriedenhagen

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2011

On Wed, Apr 13, 2011 at 00:14, dty
reply@reply.github.com
wrote:

My only comment is one about expectation. If I click on the build number, I would expect to wind up at the summary for that build, not the console. Maybe changing the status icon to be a link would be better?

Hm, that's what the span title is for :-). I see your point, though.
However, a link on an image is a bit unusual and adding a console icon
to the build history will clutter this. I will give the icon idea a
try to see how it looks like.

@mfriedenhagen

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2011

I implemented a link via the icon, see http://huschteguzzel.de/hudson/job/sardine/. However I do not know how to include a visual clue, so it would be obvious to a visitor that the icon is clickable.

@dty

This comment has been minimized.

Copy link
Member

commented Apr 12, 2011

I get a 500 error when I go to that URL.

Personally, I'm not too concerned with a visual indicator for the icon being clickable. The cursor changes to a hand when the user moves the mouse cursor over it. The same issue exists for the build progress bar that appears in the build history. Did you know that clicking on that also takes you to the console for builds in progress?

@kohsuke

This comment has been minimized.

Copy link
Member

commented Apr 13, 2011

This is probably more general comment beyond this ticket, but it'd be really nice if we have a reusable drop-down menu control that provides navigation simpler. We could use it in so many places, including here...

@mfriedenhagen

This comment has been minimized.

Copy link
Member Author

commented Apr 13, 2011

Hello, the 500 should be fixed. And yes, I did know about the progress bar
to console link. When you hover over the weather symbol, you get a health
pop-up. Anyway, I will change this patch to use your suggested link from
icon solution.

@mfriedenhagen

This comment has been minimized.

Copy link
Member Author

commented Apr 13, 2011

I rebased the diffs against a newer upstream master and link via the status icon, thanks for the suggestion, dty.
Outcome may be seen at http://huschteguzzel.de/hudson/job/sardine/ as before.
@kohsuke: while I agree that a drop-down would be handy in midterm, I really crave for the direct link to the console in shortterm ;-). When digging through 30 broken builds in the morning (not that bad as we have about 1200 jobs), the console link has helped a lot and was the only feature some developers were missing when we ditched our homegrown version against unpatched jenkins.

@mfriedenhagen

This comment has been minimized.

Copy link
Member Author

commented Apr 13, 2011

I just tried something different: On hovering over the datetime link a small div should pop up (abusing the healthReport class right now), where you might choose other links, see http://huschteguzzel.de/hudson/job/sardine/ for an example. Right now it does not check, wether changes or testreport exist, see https://github.com/mfriedenhagen/jenkins/commit/677d813147d75578fa8c089a3f3bb11a76b226a4. Works in Chrome 12, Firefox 4 and Safari 5 on MacOSX. Right now my original version with the link on the icon is more pleasant to me :-).

mfriedenhagen added a commit that referenced this pull request Apr 28, 2011

Merged pull request #93 from mfriedenhagen/master.
Link to the console output from the status icon of an entry in the HistoryWidget.

@mfriedenhagen mfriedenhagen merged commit 39d738f into jenkinsci:master Apr 28, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.