Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JEP-211] - Add Reasoning about Java 10 and Java 12 support #228

Merged
merged 7 commits into from Dec 11, 2018

Conversation

@oleg-nenashev oleg-nenashev requested a review from batmat Dec 11, 2018
Copy link

left a comment

With a minor possible fix

jep/211/README.adoc Outdated Show resolved Hide resolved
@batmat
batmat approved these changes Dec 11, 2018
Copy link
Member

left a comment

makes sense to clarify.

jep/211/README.adoc Outdated Show resolved Hide resolved
Copy link
Member

left a comment

I'm not a native speaker, but I think and in a negative sentence to add a item to the negative, should be a nor.

jep/211/README.adoc Outdated Show resolved Hide resolved
jep/211/README.adoc Outdated Show resolved Hide resolved
Copy link
Member Author

left a comment

addressed comments

jep/211/README.adoc Outdated Show resolved Hide resolved
jep/211/README.adoc Outdated Show resolved Hide resolved
jep/211/README.adoc Outdated Show resolved Hide resolved
jep/211/README.adoc Outdated Show resolved Hide resolved
jep/211/README.adoc Show resolved Hide resolved
@batmat
batmat approved these changes Dec 11, 2018
@oleg-nenashev

This comment has been minimized.

Copy link
Member Author

commented Dec 11, 2018

OK, GitHub suggestions here are not that cool :(

@oleg-nenashev oleg-nenashev merged commit dd28110 into jenkinsci:master Dec 11, 2018
@alecharp

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

I guess they are when you are not the author of the PR ;)

@oleg-nenashev oleg-nenashev deleted the oleg-nenashev:jep-211/java-support branch Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.