Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accommodate non-standard jira project keys #16

Merged

Conversation

@clover-bt
Copy link

clover-bt commented Sep 13, 2018

the default project key format consists of only letters; however, according to
https://confluence.atlassian.com/adminjiraserver071/changing-the-project-key-format-802592378.html
, the project key may also include an underscore

(accommodate an edge case, just in case)

Clover Network, Inc added 4 commits Sep 13, 2018
the default project key format consists of only letters; however, according to
https://confluence.atlassian.com/adminjiraserver071/changing-the-project-key-format-802592378.html
, the project key may also include an underscore
…into first-word-accommodate-typical-delimiters
Clover Network, Inc
Copy link
Member

dalvizu left a comment

Thank you for taking the time to submit this short and well reasoned pull request. Appreciate the eye to detail and new test cases.

@@ -72,7 +72,7 @@ public FirstWordOfCommitStrategy()
String firstWordOfTicket;
firstWordOfTicket = msg.substring(0, (msg.contains(" ") ? StringUtils.indexOf(msg, " ") : msg.length()));

final String regex = "([0-9A-Z]+-)([0-9]+)";
final String regex = "([A-Z][0-9A-Z_]+-)([0-9]+)";

This comment has been minimized.

Copy link
@dalvizu

dalvizu Sep 13, 2018

Member

JIRA tickets cannot start with numbers -- good catch

@dalvizu dalvizu merged commit fa1ceea into jenkinsci:master Sep 13, 2018
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.