Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some strange http configuration confusion between connect timeout and read timeout #166

Merged
merged 5 commits into from Oct 8, 2018

Conversation

Projects
None yet
4 participants
@olamy
Copy link
Member

commented Sep 28, 2018

Signed-off-by: olivier lamy olamy@apache.org

fix some strange http configuration confusion between connect timeout…
… and read timeout

Signed-off-by: olivier lamy <olamy@apache.org>

@olamy olamy added the WIP label Sep 28, 2018

@coveralls

This comment has been minimized.

Copy link

commented Sep 28, 2018

Coverage Status

Coverage increased (+0.5%) to 54.442% when pulling 48d24e3 on http_improvment into aae5e37 on master.

olamy added some commits Sep 29, 2018

[JENKINS-53320] fix some of the http configuration, there was a misun…
…derstanding between connection timeout and read timeout. Add a configuration of the size of the thread pools used for http calls

Signed-off-by: olivier lamy <olamy@apache.org>
get rid of circular objects references
Signed-off-by: olivier lamy <olamy@apache.org>
some cleanup
Signed-off-by: olivier lamy <olamy@apache.org>

@olamy olamy changed the title [WIP][DO NOT MERGE] fix some strange http configuration confusion between connect timeout… fix some strange http configuration confusion between connect timeout and read timeout Sep 29, 2018

remove usage of some deprecated methods, add some java8 sugar syntax
Signed-off-by: olivier lamy <olamy@apache.org>

@olamy olamy removed the WIP label Oct 8, 2018

@olamy olamy merged commit d6e924d into master Oct 8, 2018

3 of 4 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.5%) to 54.442%
Details

@olamy olamy deleted the http_improvment branch Oct 8, 2018

@parapunzi

This comment has been minimized.

Copy link

commented Oct 17, 2018

sorry to use this comments for bugreporting: had a strange issue today updating to the released JIRA plugin 3.0.3: in the Jenkins config GUI the new (?) fields 'Read timeout' and 'Thread Executor Size' both had value 0 -- and thus builds failed with 'Failed to parse changelog' and change lists had missing Jira-Links. Setting the fields to 30 and 10 fixed the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.