[JENKINS-56951] Fix folder property layout #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the folder properties list is built, it's already under a titled section see https://github.com/jenkinsci/cloudbees-folder-plugin/blob/9d87f2f197554d93a97422a010bd92087e4e576b/src/main/resources/com/cloudbees/hudson/plugins/folder/AbstractFolder/configure.jelly#L136 Adding the section title in the JiraFolderProperty configuration file broken the layout and let to think that the other properties (from other plugins) could be part of the Jira section as well. Removing the title here fix that.
jglick
reviewed
Apr 29, 2019
|
@jglick you are right, I could, the behavior is the same. Just that having a |
I think so. |
As suggested by @jglick, removing the `f:section` entirely to fix the folder property layout
|
Thanks @jglick for your time, I included your suggestion. |
jglick
approved these changes
Apr 29, 2019
rantoniuk
approved these changes
Apr 29, 2019
|
@artkoshelev @olamy could a release be possibly considered? I see there are a handful of other unreleased improvements in Thanks! |
|
Yup I can make it my tomorrow morning 1st May (AEST timezone)
On Tue, 30 Apr 2019 at 5:07 pm, Baptiste Mathus ***@***.***> wrote:
@artkoshelev <https://github.com/artkoshelev> @olamy
<https://github.com/olamy> could a release be possibly considered?
I see there are a handful of other unreleased improvements in master,
like the JCasC support in #168
<#168> among others.
Release early, often, and keep changes small ;-).
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#187 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAE2EERNCOXLAN36BFQGY3PS7VZHANCNFSM4HJEQRFQ>
.
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
|
|
Would be perfect, thanks Olivier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: JENKINS-56951
When the folder properties list is built, it's already under a titled section see
https://github.com/jenkinsci/cloudbees-folder-plugin/blob/9d87f2f197554d93a97422a010bd92087e4e576b/src/main/resources/com/cloudbees/hudson/plugins/folder/AbstractFolder/configure.jelly#L136
Adding the section title in the JiraFolderProperty configuration file broken the layout
and let to think that the other properties (from other plugins) could be part of the Jira
section as well.
Removing the title here fix that.