Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Jul 23, 2015
  1. @stefanbrausch
  2. @stefanbrausch

    Merge pull request #48 from bdkoepke/master

    stefanbrausch authored
    Refactoring of FileHistoryDao to add ExtensionPoint support.
  3. @stefanbrausch
  4. @stefanbrausch
  5. @stefanbrausch
Commits on Jul 22, 2015
  1. One final revision.

    Brandon Koepke authored
  2. Reverted unnecessary changes to simplify pull request.

    Brandon Koepke authored
  3. Changes to prepare for proper extension point support.

    Brandon Koepke authored
    Reverted .toURI().toURL() after finding that
    getConfiguredHistoryRootDir could be package protected, disabled
    testOldConfigsExist until I can figure out what is wrong with it,
    rename of HistoryDaoBackend to JobConfigHistoryStrategy,  revered
    getHistoryDao in PluginUtils (need to figure out a better method for
    extension points), created JobConfigHistoryDescriptor as the new
    extension point system.
  4. Unified license headers.

    Brandon Koepke authored
Commits on Jul 21, 2015
  1. Extracted Purgeable interface and shrunk requirements for HistoryDaoB…

    Brandon Koepke authored
    …ackend significantly. Introduced a bug with testOldConfigsExist, still need to diagnose.
  2. Fixed visibility on setUrl in FileHistoryDao.

    Brandon Koepke authored
  3. HistoryDaoBackends abstract methods were package-protected, made them…

    Brandon Koepke authored
    … public.
Commits on Jul 20, 2015
  1. Fixed unit tests that needed a trailing /, also fixed integration tes…

    Brandon Koepke authored
    …ts that were failing due to files being compared against urls.
  2. Created HistoryDaoBackend and migrated FileHistoryDao to use the back…

    Brandon Koepke authored
    …end code. PluginUtils also selects the backend provider based on the list of supported protocols as implemented by HistoryDaoBackend. This should allow ad-hoc history backends to be added to jobConfigHistory.
Commits on Jun 25, 2015
  1. @stefanbrausch

    Merge pull request #47 from abayer/jenkins-29063

    stefanbrausch authored
    JENKINS-29063 - Switch default for per-Maven modules to false.
Commits on Jun 24, 2015
  1. @abayer
Commits on Jun 22, 2015
  1. @stefanbrausch

    Merge pull request #46 from daniel-beck/JENKINS-24930

    stefanbrausch authored
    [FIXED JENKINS-24930] Alternating row bg colors
Commits on Jun 18, 2015
  1. @olivergondza

    Merge pull request #45 from olivergondza/fix-sidepanel

    olivergondza authored
    [FIXED JENKINS-25000] Show slave sidepanel
Commits on Jun 17, 2015
  1. @daniel-beck

    [FIXED JENKINS-24930] Alternating row bg colors

    daniel-beck authored
    Also switches to using the PNG icons so there's no ugly white
    background.
Commits on Jun 15, 2015
  1. @olivergondza
Commits on May 28, 2015
  1. @mfriedenhagen

    Merge pull request #44 from fbelzunc/JENKINS-28570

    mfriedenhagen authored
    [FIXED  JENKINS-28570] Allow users with Extended Read permission to read modifications in Job configurations.
  2. @fbelzunc

    [FIXED JENKINS-28570] Allow Extended Read permission to read modif in…

    fbelzunc authored
    … job configs
    
    [# FIXED JENKINS-28570] Allow users with Extended Read permission to read modifications in Job
Commits on Apr 28, 2015
  1. @mfriedenhagen

    Merge pull request #43 from jcarsique/master

    mfriedenhagen authored
    JENKINS-28129: precise file extension on default exclusions
  2. @jcarsique
Commits on Apr 17, 2015
  1. @stefanbrausch
Commits on Apr 8, 2015
  1. @stefanbrausch
  2. @stefanbrausch
  3. @stefanbrausch
  4. @stefanbrausch
  5. @stefanbrausch
  6. @stefanbrausch
Commits on Apr 7, 2015
  1. @stefanbrausch

    Merge pull request #42 from thomasgl-orange/fix-circular-dependency

    stefanbrausch authored
    Avoid calling User.current() during Jenkins initialization
Commits on Mar 27, 2015
  1. @thomasgl-orange

    Avoid calling `User.current()` from `JobConfigHistorySaveableListener…

    thomasgl-orange authored
    …` during Jenkins initialization
    
    When `jobConfigHistory` is used used together with the `sonar` (2.2) plugin, we get the following stack:
    
    ```
    hudson.ExtensionFinder$GuiceFinder$FaultTolerantScope$1 error
    WARNING: Failed to instantiate Key[type=hudson.plugins.sonar.SonarPublisher$DescriptorImpl, annotation=[none]]; skipping this component
    com.google.inject.ProvisionException: Guice provision errors:
    
    1) Tried proxying hudson.plugins.sonar.SonarPublisher$DescriptorImpl to support a circular dependency, but it is not an interface.
    
    1 error
    	at com.google.inject.internal.ProviderToInternalFactoryAdapter.get(ProviderToInternalFactoryAdapter.java:52)
    	at com.google.inject.Scopes$1$1.get(Scopes.java:65)
    	at hudson.ExtensionFinder$GuiceFinder$FaultTolerantScope$1.get(ExtensionFinder.java:427)
    	at com.google.inject.internal.InternalFactoryToProviderAdapter.get(InternalFactoryToProviderAdapter.java:41)
    	at com.google.inject.internal.InjectorImpl$3$1.call(InjectorImpl.java:1005)
    	at com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1058)
    	at com.google.inject.internal.InjectorImpl$3.get(InjectorImpl.java:1001)
    	at hudson.ExtensionFinder$GuiceFinder._find(ExtensionFinder.java:389)
    	at hudson.ExtensionFinder$GuiceFinder.find(ExtensionFinder.java:380)
    	at hudson.ClassicPluginStrategy.findComponents(ClassicPluginStrategy.java:370)
    	at hudson.ExtensionList.load(ExtensionList.java:300)
    	at hudson.ExtensionList.ensureLoaded(ExtensionList.java:253)
    	at hudson.ExtensionList.getComponents(ExtensionList.java:154)
    	at hudson.DescriptorExtensionList.load(DescriptorExtensionList.java:182)
    	at hudson.ExtensionList.ensureLoaded(ExtensionList.java:253)
    	at hudson.ExtensionList.iterator(ExtensionList.java:143)
    	at hudson.model.User.load(User.java:192)
    	at hudson.model.User.<init>(User.java:143)
    	at hudson.model.User.getOrCreate(User.java:443)
    	at hudson.model.User.current(User.java:487)
    	at hudson.plugins.jobConfigHistory.PluginUtils.getHistoryDao(PluginUtils.java:71)
    	at hudson.plugins.jobConfigHistory.PluginUtils.getHistoryDao(PluginUtils.java:62)
    	at hudson.plugins.jobConfigHistory.JobConfigHistorySaveableListener.getHistoryDao(JobConfigHistorySaveableListener.java:49)
    	at hudson.plugins.jobConfigHistory.JobConfigHistorySaveableListener.onChange(JobConfigHistorySaveableListener.java:28)
    	at hudson.model.listeners.SaveableListener.fireOnChange(SaveableListener.java:80)
    	at hudson.model.Descriptor.save(Descriptor.java:760)
    	at hudson.plugins.sonar.SonarPublisher$DescriptorImpl.<init>(SonarPublisher.java:420)
    	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
    	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
    	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
    	at java.lang.reflect.Constructor.newInstance(Constructor.java:526)
    	at com.google.inject.internal.DefaultConstructionProxyFactory$1.newInstance(DefaultConstructionProxyFactory.java:86)
    	at com.google.inject.internal.ConstructorInjector.provision(ConstructorInjector.java:108)
    	at com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:88)
    	at com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:269)
    	at com.google.inject.internal.ProviderToInternalFactoryAdapter$1.call(ProviderToInternalFactoryAdapter.java:46)
    	at com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1058)
    	at com.google.inject.internal.ProviderToInternalFactoryAdapter.get(ProviderToInternalFactoryAdapter.java:40)
    	at com.google.inject.Scopes$1$1.get(Scopes.java:65)
    	at hudson.ExtensionFinder$GuiceFinder$FaultTolerantScope$1.get(ExtensionFinder.java:427)
    	at com.google.inject.internal.InternalFactoryToProviderAdapter.get(InternalFactoryToProviderAdapter.java:41)
    	at com.google.inject.internal.InjectorImpl$3$1.call(InjectorImpl.java:1005)
    	at com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1051)
    	at com.google.inject.internal.InjectorImpl$3.get(InjectorImpl.java:1001)
    	at hudson.ExtensionFinder$GuiceFinder._find(ExtensionFinder.java:389)
    	at hudson.ExtensionFinder$GuiceFinder.find(ExtensionFinder.java:380)
    	at hudson.ClassicPluginStrategy.findComponents(ClassicPluginStrategy.java:370)
    	at hudson.ExtensionList.load(ExtensionList.java:300)
    	at hudson.ExtensionList.ensureLoaded(ExtensionList.java:253)
    	at hudson.ExtensionList.getComponents(ExtensionList.java:154)
    	at hudson.DescriptorExtensionList.load(DescriptorExtensionList.java:182)
    	at hudson.ExtensionList.ensureLoaded(ExtensionList.java:253)
    	at hudson.ExtensionList.iterator(ExtensionList.java:143)
    	at org.jenkinsci.plugins.xunit.AliasInitializer.addAliases(AliasInitializer.java:47)
    	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    	at java.lang.reflect.Method.invoke(Method.java:606)
    	at hudson.init.TaskMethodFinder.invoke(TaskMethodFinder.java:105)
    	at hudson.init.TaskMethodFinder$TaskImpl.run(TaskMethodFinder.java:169)
    	at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:282)
    	at jenkins.model.Jenkins$7.runTask(Jenkins.java:903)
    	at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:210)
    	at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
    	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
    	at java.lang.Thread.run(Thread.java:745)
    ```
    
    When writing the `SonarPublisher` config, `JobConfigHistorySaveableListener` is triggered, leading to a `User.current()` call, and ultimately to a Guice error (circular dependency).
    Since config changes occuring during this startup phase are not linked to any user request, we can avoid the `User.current()` call, and keep the config history entry anonymous.
    Note this is kind if similar to JENKINS-20988.
Commits on Dec 18, 2014
  1. @stefanbrausch

    Merge pull request #41 from jglick/test-against-new-baseline

    stefanbrausch authored
    Allow plugin to compile against newer baselines
Something went wrong with that request. Please try again.