Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-29383] Fix handling of special chars in aggregated matrix reports #21

Merged
merged 1 commit into from Jul 17, 2015

Conversation

Projects
None yet
3 participants
@olivergondza
Copy link
Member

commented Jul 13, 2015

The path can contain url-encoded special characters. Passing it to the javascript
function over href="javascript:..." decodes at least some of the characters so
showFailureSummary function search decoded version of element IDs and fails when
the decoded string differs. This change uses onclick event instead, where arguments
are not url-decoded.

[FIXED JENKINS-29383] Fix handling of special chars in aggregated mat…
…rix reports

The path can contain url-encoded special characters. Passing it to the javascript
function over `href="javascript:..."` decodes at least some of the characters so
showFailureSummary function search decoded version of element IDs and fails when
the decoded string differs. This change uses onclick event instead, where arguments
are not url-decoded.
@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Jul 13, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Jul 16, 2015

👍

@olivergondza olivergondza merged commit f81c822 into jenkinsci:master Jul 17, 2015

1 check passed

Jenkins This pull request looks good
Details

olivergondza added a commit that referenced this pull request Jul 17, 2015

Merge pull request #21 from olivergondza/special-chars
[FIXED JENKINS-29383] Fix handling of special chars in aggregated matrix reports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.