Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-12815] - Added option allowing empty test results. #28

Merged
merged 2 commits into from Nov 24, 2015

Conversation

Projects
None yet
7 participants
@per-bohlin
Copy link

per-bohlin commented Oct 10, 2015

This is an attempt at solving one aspect of JENKINS-12815 (https://issues.jenkins-ci.org/browse/JENKINS-12815). This implementation does not allow for setting the build status on missing files, but a simple check-box to allow empty results at all. I hope it is a reasonable compromise between the functionality needed by many (myself included) to allow for missing test files and not to clutter the GUI with too many options.

@jenkinsadmin

This comment has been minimized.

Copy link
Member

jenkinsadmin commented Oct 11, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@per-bohlin

This comment has been minimized.

Copy link
Author

per-bohlin commented Oct 11, 2015

Updates:
I realized I've broken backward compatibility by changing the constructor of one of the semi-internal classes. Updated the class with overloaded constructor with new new parameters instead; preserving the old interface as well.

@per-bohlin

This comment has been minimized.

Copy link
Author

per-bohlin commented Nov 1, 2015

It solves JENKINS-22747 (https://issues.jenkins-ci.org/browse/JENKINS-22747), which is a variant of JENKINS-12815.

@jplandolt

This comment has been minimized.

Copy link

jplandolt commented Nov 2, 2015

Glad that we're on the same page. When will this pull get accepted?

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Nov 11, 2015

I suppose somebody should take an action and to merge pending PRs and release the plugin.
The plugin has no maintainer, so somebody from @jenkinsci/core could do it. Added to my TODO list for the weekend.

@jplandolt

This comment has been minimized.

Copy link

jplandolt commented Nov 11, 2015

Thanks Oleg
On Nov 11, 2015 4:24 PM, "Oleg Nenashev" notifications@github.com wrote:

I suppose somebody should take an action and to merge pending PRs and
release the plugin.
The plugin has no maintainer, so somebody from @jenkinsci/core
https://github.com/orgs/jenkinsci/teams/core could do it. Added to my
TODO list for the weekend.


Reply to this email directly or view it on GitHub
#28 (comment)
.

}

/**
* @param keepLongStdio if true, retain a suite's complete stdout/stderr even if this is huge and the suite passed
* @since 1.358
*/
@Deprecated

This comment has been minimized.

Copy link
@jtnord

jtnord Nov 12, 2015

Member

nit: newly deprecated code should also have a javadoc @deprecated tag saying what you should use instead.

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Nov 16, 2015

Sorry, didn't find time to handle this on the weekend. It is in my TODO queue and impacts my karma, so I hope to do it ASAP

@jplandolt

This comment has been minimized.

Copy link

jplandolt commented Nov 16, 2015

Thanks for letting us know, Oleg. Do you need any support after it's
managed?

On 16 November 2015 at 03:27, Oleg Nenashev notifications@github.com
wrote:

Sorry, didn't find time to handle this on the weekend. It is in my TODO
queue and impacts my karma, so I hope to do it ASAP


Reply to this email directly or view it on GitHub
#28 (comment)
.

@jplandolt

This comment has been minimized.

Copy link

jplandolt commented Nov 24, 2015

Any sense on when this is going to happen?

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Nov 24, 2015

I've performed manual tests on the weekend and everything seems to be fine. Going forward with the merge

oleg-nenashev added a commit that referenced this pull request Nov 24, 2015

Merge pull request #28 from devconsoft/master
Added option allowing empty test results.

@oleg-nenashev oleg-nenashev merged commit b625126 into jenkinsci:master Nov 24, 2015

1 check passed

Jenkins This pull request looks good
Details

@oleg-nenashev oleg-nenashev added this to the 1.10 milestone Nov 24, 2015

@oleg-nenashev oleg-nenashev changed the title Added option allowing empty test results. [JENKINS-12815] - Added option allowing empty test results. Dec 11, 2015

@rpionke

This comment has been minimized.

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Dec 14, 2015

@rpionke
Sure

@orrc

This comment has been minimized.

Looks like a comment didn't get removed at some point.

image

openstack-gerrit added a commit to openstack/openstack that referenced this pull request Aug 18, 2016

Updated openstack/openstack
Project: openstack-infra/jenkins-job-builder  d363b7a247ca8b0ff25ca303d442cddfde15975e

Add support for enabling empty results

needs jenkinsci/junit-plugin#28 merged and released

Change-Id: Id033495dcc97c8562b173fa419fc8312467ccf9a

openstack-gerrit pushed a commit to openstack-infra/jenkins-job-builder that referenced this pull request Aug 18, 2016

Add support for enabling empty results
needs jenkinsci/junit-plugin#28 merged and released

Change-Id: Id033495dcc97c8562b173fa419fc8312467ccf9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.