Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added '<' and '>' as unsafe URI characters. #56

Merged
merged 2 commits into from Oct 3, 2016

Conversation

@FrelliBB
Copy link

FrelliBB commented Sep 30, 2016

I opened this pull request due to the safe() function not replacing the < and > characters. This was triggered due to the cucumber-testresult-plugin using the getSafeName() for Scenarios and Features as file names when publishing reports (https://github.com/jenkinsci/cucumber-testresult-plugin/blob/master/src/main/java/org/jenkinsci/plugins/cucumber/jsontestsupport/CucumberTestResultArchiver.java).

Cucumber Scenarios can have the < and > characters in the scenario names (https://github.com/cucumber/cucumber/wiki/Scenario-Outlines) and as such these unsafe characters were preventing the results from being published to Jenkins.

Francesco Borg Bonaci added 2 commits Sep 30, 2016
@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Sep 30, 2016

Looks good to me 👍
CC @jtnord , who is a maintainer of cucumber-testresult-plugin

@oleg-nenashev oleg-nenashev merged commit 544f4d5 into jenkinsci:master Oct 3, 2016
1 check passed
1 check passed
Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.