Minor refactoring.

jenkinsci · Jul 9, 2011 · e3d7cfb · e3d7cfb
1 parent ba8090f
commit e3d7cfb
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/jython-plugin/src/main/java/org/jvnet/hudson/plugins/JythonComputerListener.java b/jython-plugin/src/main/java/org/jvnet/hudson/plugins/JythonComputerListener.java
@@ -29,7 +29,7 @@ public void preOnline(
             JythonPlugin.syncSitePackages(jythonHome, listener);
             jythonHome.child("jython").chmod(0755);
             jythonHome.child("tmp").mkdirs();
-            listener.getLogger().println("Installed Jython runtime.");
+            listener.getLogger().println("Installed Jython runtime");
         }
     }
 }
diff --git a/jython-plugin/src/main/java/org/jvnet/hudson/plugins/JythonPlugin.java b/jython-plugin/src/main/java/org/jvnet/hudson/plugins/JythonPlugin.java
@@ -78,7 +78,7 @@ public void start() throws Exception {
             JYTHON_HOME.unzipFrom(INSTALLER_URL.openStream());
             JYTHON_HOME.child("jython").chmod(0755);
             JYTHON_HOME.child("tmp").mkdirs();
-            LOG.info("Installed Jython runtime.");
+            LOG.info("Installed Jython runtime");
         }
     }
 }
diff --git a/jython-plugin/src/main/java/org/jvnet/hudson/plugins/PythonPackage.java b/jython-plugin/src/main/java/org/jvnet/hudson/plugins/PythonPackage.java
@@ -59,6 +59,7 @@ private void invokeJython(String scriptPath, List<String> options) {
             ProcessBuilder procBuilder = new ProcessBuilder(procCmd).
                 redirectErrorStream(true);
 
+            // Set "http_proxy" environment variable to Jenkins proxy value
             ProxyConfiguration proxy = Hudson.getInstance().proxy;
             if (proxy != null) {
                 procBuilder.environment().put(
@@ -69,7 +70,6 @@ private void invokeJython(String scriptPath, List<String> options) {
                 new InputStreamReader(proc.getInputStream()));
             StringBuilder lines = new StringBuilder();
             String line = stdOut.readLine();
-            boolean nameSet = false;
             while (line != null) {
                 System.out.println(line);
                 lines.append(line);