Document restart not required #6
Conversation
| */ | ||
| private void registerFilter() throws ServletException { | ||
| this.filter = new KerberosSSOFilter(createConfigMap(), new SpnegoKerberosAuthenticationFactory()); | ||
| PluginServletFilter.addFilter(filter); |
There was a problem hiding this comment.
But here you are effectively just adding a new instance to a list of filters already containing older instances with the old config no?
There was a problem hiding this comment.
In this method, yes. The calling code is supposed to deal with that by removing the filter first in case it is re-adding.
There was a problem hiding this comment.
This particular refactorization just replaced a verbatim copy of the same code present on both places already. I am quite confident about this part of the patch.
There was a problem hiding this comment.
Yes, the refactoring is fine, I just wanted to point out where my concern was about that a restart might still be required. But I trust your judgement :)
|
I have retested with end-to-end tests locally: jenkinsci/acceptance-test-harness#192 |
I do not see a reason why restart would be required after dd64a55. My tests does neither.