Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource support #88

Merged
merged 1 commit into from Jul 19, 2019
Merged

Resource support #88

merged 1 commit into from Jul 19, 2019

Conversation

@runzexia
Copy link
Member

runzexia commented Jul 11, 2019

No description provided.

@runzexia runzexia changed the title [WIP] migrate sdk full change Resource support Jul 16, 2019
@runzexia

This comment has been minimized.

Copy link
Member Author

runzexia commented Jul 16, 2019

I think I can now do some code review. @gavinfish
There are many codes in this PR, but most of them are similar.

Three of these resources are special: V1Job, V1Pod, V1Statefulset.
These resources cannot be directly put into the kubernetes apiserver.
Some default values are not allowed to be changed.
So I get these defaults through server dryRun and construct putObject

@gavinfish

This comment has been minimized.

Copy link
Member

gavinfish commented Jul 17, 2019

@runzexia sorry for my late response for this plugin since I have limit bandwidth for Jenkins related staff recently.
I think we are really close to release a new version to introduce the new SDK. I have run some simple tests with some kind of kubernetes resources on the latest branch and it works fine.

Still more review work and tests are needed before we release it.

Copy link
Member

gavinfish left a comment

I have just reviewed the remaining code. Please help me understand more about the details @runzexia thanks😃

Copy link
Member

gavinfish left a comment

LGTM, let us try to release a preview version.

Signed-off-by: runzexia <runzexia@yunify.com>
@runzexia runzexia force-pushed the runzexia:full-change branch from 149d9bd to 2907a96 Jul 19, 2019
@gavinfish gavinfish merged commit 055da1d into jenkinsci:migrate_sdk Jul 19, 2019
1 check was pending
1 check was pending
continuous-integration/jenkins/pr-merge This commit is being built
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.