New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use slave template namespace in logs #304

Merged
merged 1 commit into from Apr 6, 2018

Conversation

Projects
None yet
3 participants
@MarkTickner

MarkTickner commented Apr 6, 2018

This defaults to client namespace as before. Currently it logs the master namespace, even if the slaves are being provisioned elsewhere.

Use slave template namespace in logs
This defaults to client namespace as before
@oliverlockwood

This comment has been minimized.

oliverlockwood commented Apr 6, 2018

For a bit more context, example logs from this before the fix:

INFO: Total container cap of 5 reached, not provisioning: 5 running or errored in namespace jenkins-master with Kubernetes labels {jenkins=slave}

versus

INFO: Created Pod: jenkins-slave-uber-s75w0 in namespace jenkins-slaves

@carlossg carlossg merged commit 97f1697 into jenkinsci:master Apr 6, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@carlossg

This comment has been minimized.

carlossg commented Apr 6, 2018

Thanks!

@MarkTickner MarkTickner deleted the sky-uk:fix-slave-provisioning-logs branch Apr 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment