Resolve NPE merging yaml when resource requests/limits are not set #310
If you have a
This PR defensively codes to cover that case.
Is this the proper fix? Either this change or something that was merged later results in objects that match the schema, but are rejected by the API server at validation time. The test case checks the former, but not the latter (which would require the Kubernetes Golang codebase). I suspect the
This is what I am seeing if I don't specify all limits and requests, with line splits added for clarity:
The object might be well-formed, but the server rejects it at validation time and returns a 400, at least with Kubernetes 1.10.
Proof that empty strings are problematic:
Reverting to 1.5.2 results in NPEs, of course. 1.6.0 has the same validation errors. I can file an issue in the tracker with all the above.