Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
transfer any master proxy related envs that the remoting jar uses to … #321
…the pod templates
hey @carlossg - this PR as much is intending to initiate discussion; @bparees and I have had a recent customer situation where they are leverage jenkins on openshift with http_proxy and no_proxy employed
one of the customer's complaints was why could he not set the env's the remoting jar was looking for on the master and then have them propagated by default to each of his pod templates
as I mentioned in the TODO I can certainly add some level of on/off configuration switch if desired (preserving default behavior, etc.) but wanted to get some form of general consensus before investing addition time
Also, as an fyi, I briefly toyed with tweaking org.csanchez.jenkins.plugins.kubernetes.pipeline.PodTemplateStepExecution to propagate the env vars for users of this plugin's pipeline DSL, but sided on being conservative, and left it alone.
But of course let me know if you would like an update there as well.