New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transfer any master proxy related envs that the remoting jar uses to … #321

Merged
merged 1 commit into from May 23, 2018

Conversation

Projects
None yet
2 participants
@gabemontero

gabemontero commented May 8, 2018

…the pod templates

hey @carlossg - this PR as much is intending to initiate discussion; @bparees and I have had a recent customer situation where they are leverage jenkins on openshift with http_proxy and no_proxy employed

one of the customer's complaints was why could he not set the env's the remoting jar was looking for on the master and then have them propagated by default to each of his pod templates

as I mentioned in the TODO I can certainly add some level of on/off configuration switch if desired (preserving default behavior, etc.) but wanted to get some form of general consensus before investing addition time

thanks

@carlossg

This comment has been minimized.

carlossg commented May 9, 2018

Thanks!
I see a problem when the jenkins master runs outside kubernetes, so I think this should be opt-in in some way

@gabemontero

This comment has been minimized.

gabemontero commented May 9, 2018

Roger that @carlossg

Would you prefer the config checkbox be in the "advanced" section, or are you fine with it being a peer with the other config settings?

@gabemontero

This comment has been minimized.

gabemontero commented May 9, 2018

Also, as an fyi, I briefly toyed with tweaking org.csanchez.jenkins.plugins.kubernetes.pipeline.PodTemplateStepExecution to propagate the env vars for users of this plugin's pipeline DSL, but sided on being conservative, and left it alone.

But of course let me know if you would like an update there as well.

@gabemontero

This comment has been minimized.

gabemontero commented May 9, 2018

opt-in addition pushed

@gabemontero

This comment has been minimized.

gabemontero commented May 14, 2018

bump @carlossg

@carlossg carlossg merged commit 57321be into jenkinsci:master May 23, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@gabemontero gabemontero deleted the gabemontero:seed_master_proxy_envs_to_agents branch May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment