Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not consider Succeeded slaves when checking container cap #323

Conversation

Projects
None yet
2 participants
@adamdougal
Copy link

adamdougal commented May 16, 2018

When checking we have not exceeded the container cap we should not consider Succeeded slaves as they do not take up resources. Not doing so means you hit the container cap even when there are no active slaves present stopping the plugin from creating new slaves.

This replaces this PR #170

Do not consider Succeeded slaves when checking container cap
When checking we have not exceeded the container cap we should not consider Succeeded slaves as they do not take up resources. Not doing so means you hit the container cap even when there are no active slaves present stopping the plugin from creating new slaves.

This replaces this PR #170
@carlossg

This comment has been minimized.

Copy link

carlossg commented May 22, 2018

I think #322 is fixing the actual cause

@carlossg

This comment has been minimized.

Copy link

carlossg commented May 22, 2018

as mentioned in #170 there should never be succeeded pods. You may be hitting #325

@carlossg carlossg added the duplicate label May 23, 2018

@carlossg

This comment has been minimized.

Copy link

carlossg commented May 23, 2018

see also #252

@carlossg carlossg closed this Jun 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.