Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[JENKINS-50268] instanceCap reached with preexisting pods #325
Conversation
This was referenced May 22, 2018
carlossg
merged commit aa3b0ed
into
master
May 24, 2018
1 check passed
continuous-integration/jenkins/branch
This commit looks good
Details
carlossg
deleted the
JENKINS-50268
branch
May 24, 2018
| @@ -325,9 +325,15 @@ public int getConnectTimeout() { | ||
| * Labels for all pods started by the plugin | ||
| */ | ||
| public Map<String, String> getLabels() { | ||
| return labels == null ? Collections.emptyMap() : labels; | ||
| return labels == null || labels.isEmpty() ? DEFAULT_POD_LABELS : labels; |
This comment has been minimized.
This comment has been minimized.
Vlatombe
May 25, 2018
Member
Given the current value of DEFAULT_POD_LABELS, the problem would be the same if you have several Jenkins instances running in the same namespace.
Maybe the DEFAULT_POD_LABELS should contain a reference to the current Jenkins instance (root url?) and cloud name in order to disambiguate.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
carlossg commentedMay 22, 2018
•
edited
because labels are empty
Supersedes #322 #320