Added a generic method to create then run a pipeline based on the current method name #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent method name Resolves $NAME to the current name when used in the current pipeline script before running it. This makes the pipeline scripts more portable.
jglick
changed the title
jglick
approved these changes
Jul 2, 2019
There was a problem hiding this comment.
Good enough for now. This idiom is not safe for concurrent builds—if the pod template in Jenkinsfile changes between builds, you could wind up running a build on the wrong node—but that is presumably not an issue in these tests. That problem is easily solved even for production pipelines by using, say,
podTemplate(label: BUILD_TAG/*, …*/) {
node(BUILD_TAG) {
// …
}
}though this breaks for project names which are not legitimate Kubernetes names. I already have a plan to deal with that, JENKINS-57830, which could also be used for tests and thus supersede this when implemented.
|
Need to fix some remaining tests I didn't update w.r.t the changed groovy files |
jglick
approved these changes
Jul 2, 2019
src/test/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/KubernetesPipelineTest.java
Outdated
Show resolved
Hide resolved
|
Merged this into my own PRs (#461, #490, #503, #522). Build failures seem to be a proxy issue: INFRA-2164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves $NAME to the current name when used in the current pipeline script before running it. This makes the pipeline scripts more portable.