Read and connect timeout are now correctly used to configure the client. #82

Merged
merged 1 commit into from Nov 8, 2016

Projects

None yet

2 participants

@iocanel
iocanel commented Oct 26, 2016

No description provided.

@carlossg

Tests are failing, and can you keep backwards compatibility?

Thanks

public KubernetesFactoryAdapter(String serviceAddress, @CheckForNull String caCertData,
- @CheckForNull String credentials, boolean skipTlsVerify) {
- this(serviceAddress, null, caCertData, credentials, skipTlsVerify);
+ @CheckForNull String credentials, boolean skipTlsVerify, int readTimeout, int connectTimeout) {
@carlossg
carlossg Oct 26, 2016

Can you keep backwards compatibility?

}
public KubernetesFactoryAdapter(String serviceAddress, String namespace, @CheckForNull String caCertData,
- @CheckForNull String credentials, boolean skipTlsVerify) {
+ @CheckForNull String credentials, boolean skipTlsVerify, int connectTimeout, int readTimeout) {
@carlossg
carlossg Oct 26, 2016

Can you keep backwards compatibility?

@iocanel
iocanel commented Oct 26, 2016

Tests are failing for reasons not related with the pull requests.

@carlossg

Unfortunately I'm on vacation without my laptop and can't fix it, and github doesn't let me merge from the phone :(

Pull requests that have a failing status can’t be merged on a phone.

@iocanel
iocanel commented Oct 27, 2016

No worries! Have fun!!!

@carlossg carlossg merged commit d9054af into jenkinsci:master Nov 8, 2016

1 check failed

Jenkins Looks like there's a problem with this pull request
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment