New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read and connect timeout are now correctly used to configure the client. #82

Merged
merged 1 commit into from Nov 8, 2016

Conversation

Projects
None yet
2 participants
@iocanel

iocanel commented Oct 26, 2016

No description provided.

@carlossg

Tests are failing, and can you keep backwards compatibility?

Thanks

Show outdated Hide outdated ...va/org/csanchez/jenkins/plugins/kubernetes/KubernetesFactoryAdapter.java
public KubernetesFactoryAdapter(String serviceAddress, @CheckForNull String caCertData,
@CheckForNull String credentials, boolean skipTlsVerify) {
this(serviceAddress, null, caCertData, credentials, skipTlsVerify);
@CheckForNull String credentials, boolean skipTlsVerify, int readTimeout, int connectTimeout) {

This comment has been minimized.

@carlossg

carlossg Oct 26, 2016

Can you keep backwards compatibility?

@carlossg

carlossg Oct 26, 2016

Can you keep backwards compatibility?

Show outdated Hide outdated ...va/org/csanchez/jenkins/plugins/kubernetes/KubernetesFactoryAdapter.java
}
public KubernetesFactoryAdapter(String serviceAddress, String namespace, @CheckForNull String caCertData,
@CheckForNull String credentials, boolean skipTlsVerify) {
@CheckForNull String credentials, boolean skipTlsVerify, int connectTimeout, int readTimeout) {

This comment has been minimized.

@carlossg

carlossg Oct 26, 2016

Can you keep backwards compatibility?

@carlossg

carlossg Oct 26, 2016

Can you keep backwards compatibility?

@iocanel

This comment has been minimized.

Show comment
Hide comment
@iocanel

iocanel Oct 26, 2016

Tests are failing for reasons not related with the pull requests.

iocanel commented Oct 26, 2016

Tests are failing for reasons not related with the pull requests.

@carlossg

This comment has been minimized.

Show comment
Hide comment
@carlossg

carlossg Oct 27, 2016

Unfortunately I'm on vacation without my laptop and can't fix it, and github doesn't let me merge from the phone :(

Pull requests that have a failing status can’t be merged on a phone.

carlossg commented Oct 27, 2016

Unfortunately I'm on vacation without my laptop and can't fix it, and github doesn't let me merge from the phone :(

Pull requests that have a failing status can’t be merged on a phone.

@iocanel

This comment has been minimized.

Show comment
Hide comment
@iocanel

iocanel Oct 27, 2016

No worries! Have fun!!!

iocanel commented Oct 27, 2016

No worries! Have fun!!!

@carlossg carlossg merged commit d9054af into jenkinsci:master Nov 8, 2016

1 check failed

Jenkins Looks like there's a problem with this pull request
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment