New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: instanceCap should be podTemplate field #92

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@zoumo

zoumo commented Nov 24, 2016

No description provided.

@carlossg

This comment has been minimized.

Show comment
Hide comment
@carlossg

carlossg Nov 29, 2016

I don't think instanceCap is even used in the pipeline syntax

carlossg commented Nov 29, 2016

I don't think instanceCap is even used in the pipeline syntax

@zoumo

This comment has been minimized.

Show comment
Hide comment
@zoumo

zoumo Nov 30, 2016

@carlossg
Yes, the instanceCap field now is useless in the pipeline syntax.

But there is an field instanceCapStr in jenkins globle settings that will change the true instanceCap field in podTemplate.

So I think instanceCap in pipeline should be podTemplate level field not containerTemplate level field
even if it is not effective

Thanks

zoumo commented Nov 30, 2016

@carlossg
Yes, the instanceCap field now is useless in the pipeline syntax.

But there is an field instanceCapStr in jenkins globle settings that will change the true instanceCap field in podTemplate.

So I think instanceCap in pipeline should be podTemplate level field not containerTemplate level field
even if it is not effective

Thanks

@carlossg carlossg closed this in ab6a5e1 Nov 30, 2016

@carlossg

This comment has been minimized.

Show comment
Hide comment
@carlossg

carlossg Nov 30, 2016

I've removed it from the example as it doesn't work there

carlossg commented Nov 30, 2016

I've removed it from the example as it doesn't work there

@zoumo zoumo deleted the zoumo:patch-1 branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment