New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pod watcher now checks readiness of the right pod. #97

Merged
merged 1 commit into from Dec 1, 2016

Conversation

Projects
None yet
3 participants
@iocanel

iocanel commented Dec 1, 2016

No description provided.

@JeanMertz

This comment has been minimized.

Show comment
Hide comment
@JeanMertz

JeanMertz Dec 1, 2016

This solves the issue I described in #95 (comment)

👍

JeanMertz commented Dec 1, 2016

This solves the issue I described in #95 (comment)

👍

@iocanel

This comment has been minimized.

Show comment
Hide comment
@iocanel

iocanel Dec 1, 2016

@carlossg: So, do we review everything, or simple commits like this can go in directly?

iocanel commented Dec 1, 2016

@carlossg: So, do we review everything, or simple commits like this can go in directly?

@carlossg

This comment has been minimized.

Show comment
Hide comment
@carlossg

carlossg Dec 1, 2016

we can use github PR review for now, but you can create the branches in this repo if it is easier to share work

carlossg commented Dec 1, 2016

we can use github PR review for now, but you can create the branches in this repo if it is easier to share work

@iocanel iocanel merged commit 8b2889b into jenkinsci:master Dec 1, 2016

1 check passed

Jenkins This pull request looks good
Details
@JeanMertz

This comment has been minimized.

Show comment
Hide comment
@JeanMertz

JeanMertz Dec 1, 2016

While we're at it, quick question:

Does Jenkins/the community require that issues are reported through Jira, or can GitHub Issues also be enabled on this repository?

Just asking, because I'm not really a fan of Jira and to me it feels like an extra barrier compared to GitHub issues, but I can understand that it makes global ticket/issue management of all things Jenkins a lot easier if it's all combined in one system.

JeanMertz commented Dec 1, 2016

While we're at it, quick question:

Does Jenkins/the community require that issues are reported through Jira, or can GitHub Issues also be enabled on this repository?

Just asking, because I'm not really a fan of Jira and to me it feels like an extra barrier compared to GitHub issues, but I can understand that it makes global ticket/issue management of all things Jenkins a lot easier if it's all combined in one system.

@carlossg

This comment has been minimized.

Show comment
Hide comment
@carlossg

carlossg Dec 1, 2016

They should go through Jira

carlossg commented Dec 1, 2016

They should go through Jira

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment