The pod watcher now checks readiness of the right pod. #97

Merged
merged 1 commit into from Dec 1, 2016

Projects

None yet

3 participants

@iocanel
iocanel commented Dec 1, 2016

No description provided.

@JeanMertz

This solves the issue I described in #95 (comment)

👍

@iocanel
iocanel commented Dec 1, 2016 edited

@carlossg: So, do we review everything, or simple commits like this can go in directly?

@carlossg
carlossg commented Dec 1, 2016 edited

we can use github PR review for now, but you can create the branches in this repo if it is easier to share work

@iocanel iocanel merged commit 8b2889b into jenkinsci:master Dec 1, 2016

1 check passed

Jenkins This pull request looks good
Details
@JeanMertz

While we're at it, quick question:

Does Jenkins/the community require that issues are reported through Jira, or can GitHub Issues also be enabled on this repository?

Just asking, because I'm not really a fan of Jira and to me it feels like an extra barrier compared to GitHub issues, but I can understand that it makes global ticket/issue management of all things Jenkins a lot easier if it's all combined in one system.

@carlossg
carlossg commented Dec 1, 2016

They should go through Jira

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment