Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-40621] Prevent leaked file descriptors. #5

Merged
merged 1 commit into from Jan 8, 2017

Conversation

Projects
None yet
6 participants
@abayer
Copy link
Member

commented Dec 22, 2016

JENKINS-40621

I think this is right? I couldn't quite match the equivalent change in core (jenkinsci/jenkins@37edc1a) due to Java 6 (yaaaaay), but tests do seem to pass...

cc @reviewbybees esp @oleg-nenashev @aheritier and also @olamy

@reviewbybees

This comment has been minimized.

Copy link

commented Dec 22, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Dec 22, 2016

What does block us from updating to Java 7? Not a big problem anyway.
BTW the PR build has not even started :(

@abayer

This comment has been minimized.

Copy link
Member Author

commented Dec 22, 2016

I'll let @aheritier and @olamy speak to the Java 7 drama. =) PR build kicked off and had a test with an error...not sure what's going on, so I kicked another.

@olamy

This comment has been minimized.

Copy link
Member

commented Dec 23, 2016

@abayer what is the drama? I don't remember. IMHO in 2017 it won't be a big problem to have 1.7 as a prerequisite :-)

@aheritier

This comment has been minimized.

Copy link
Member

commented Dec 29, 2016

I don't really remember where this lib is used but the maven plugin 2.14+ is now in java 7 thus no problem to upgrade https://wiki.jenkins-ci.org/display/JENKINS/Maven+Project+Plugin

@aheritier

This comment has been minimized.

Copy link
Member

commented Dec 29, 2016

@aheritier

This comment has been minimized.

Copy link
Member

commented Dec 29, 2016

I don't see how this code changed could create the test failure we are seeing but something is wrong in that lib
🐝 for the PR

@olamy

This comment has been minimized.

Copy link
Member

commented Dec 30, 2016

@aheritier this lib is used in the maven plugin

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Dec 30, 2016

And also in several other plugins. In particular, this bugged call is being used in Maven plugin and Artifactory plugin (see the JIRA ticket).

If we're fine with tests, 🐝

@stephenc

This comment has been minimized.

Copy link
Member

commented Jan 4, 2017

@abayer abayer merged commit a1d7a99 into jenkinsci:master Jan 8, 2017

1 check was pending

Jenkins Jenkins is validating pull request ...
Details
@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Jan 11, 2017

@abayer I have no idea who is supposed to do the release now. https://github.com/jenkins-infra/repository-permissions-updater has no entries for this lib. @olamy would you like to continue maintaining it?

@olamy

This comment has been minimized.

Copy link
Member

commented Jan 11, 2017

@aheritier

This comment has been minimized.

Copy link
Member

commented Jan 11, 2017

If useful you can add me too. I never had to touch to this lib but I'm contributing to the maven-plugin thus it might be useful

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Jan 11, 2017

will add several people from the core team. Just to share the guilt :D

@aheritier

This comment has been minimized.

Copy link
Member

commented Jan 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.