New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locking for freestyle jobs #80

Merged
merged 1 commit into from Nov 13, 2017

Conversation

Projects
None yet
4 participants
@Aga303

Aga303 commented Oct 31, 2017

Freestyle jobs did not hold the resource locks properly,
as they did not record the queueProjectName to the queue.
Any blocked jobs would give up waiting after QUEUE_TIMEOUT
seconds in the queue, even if there was a job blocking.

Fixes: JENKINS-47754

Fix locking for freestyle jobs
Freestyle jobs did not hold the resource locks properly,
as they did not record the queueProjectName to the queue.
Any blocked jobs would give up waiting after QUEUE_TIMEOUT
seconds in the queue, even if there was a job blocking.

Fixes: JENKINS-47754
@nkuttler

This comment has been minimized.

Show comment
Hide comment
@nkuttler

nkuttler Nov 13, 2017

Is there an older version available without this bug?

nkuttler commented Nov 13, 2017

Is there an older version available without this bug?

@Aga303

This comment has been minimized.

Show comment
Hide comment
@Aga303

Aga303 Nov 13, 2017

@nkuttler The former release (1.11.2) does not seem to have this bug.

Aga303 commented Nov 13, 2017

@nkuttler The former release (1.11.2) does not seem to have this bug.

@nkuttler

This comment has been minimized.

Show comment
Hide comment
@nkuttler

nkuttler Nov 13, 2017

Thanks, I can confirm it works and can live with the security implications.

nkuttler commented Nov 13, 2017

Thanks, I can confirm it works and can live with the security implications.

@abayer

abayer approved these changes Nov 13, 2017

Sorry for missing this - looks good.

@abayer abayer merged commit 84fa501 into jenkinsci:master Nov 13, 2017

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@Aga303 Aga303 deleted the Aga303:fix-locking branch Nov 13, 2017

@anderso1

This comment has been minimized.

Show comment
Hide comment
@anderso1

anderso1 Dec 15, 2017

I'm running version 2.1 (with freestyle jobs) and the lock seems only to be working when I trigger builds manually. If a build starts as a result of "Poll SCM" then the resource is not locked.

anderso1 commented Dec 15, 2017

I'm running version 2.1 (with freestyle jobs) and the lock seems only to be working when I trigger builds manually. If a build starts as a result of "Poll SCM" then the resource is not locked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment