Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-38381] Pipeline remote build logging #18

Closed
wants to merge 53 commits into from

Conversation

@jglick
Copy link
Member

commented Oct 14, 2016

JENKINS-38381

Implements an SPI in jenkinsci/workflow-job-plugin#27 to provide remote logging of builds.

Mostly the work of others; my addition is mainly in 7d92624, with some notes.

Demo is in Docker Compose format in the demo/ subdirectory. Instructions

@reviewbybees esp. @oleg-nenashev

oleg-nenashev and others added 30 commits Sep 16, 2016
Upgrade the plugin to the latest Parent POM and to 1.625.3 baseline.
The plugin suports Java 7 only, hence such upgrade is really reasonable
Save the progress.
* Kibana Embedded Log is more or less operational
* Elasticsearch Javascript-based fetching code does not work with the reference search filter
jglick added 4 commits Dec 21, 2016
@touchbeamTeamcity

This comment has been minimized.

Copy link

commented Jan 30, 2017

any news about this ?

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Mar 27, 2017

@touchbeamTeamcity I still think we need some time to finally test it and to re-integrate the Freestyle project support. Since there is a new maintainer of this plugin, I suppose we would be able to discuss the next steps on this front with him once he unravels other stuff. CC @jakub-bochenski

@jakub-bochenski

This comment has been minimized.

Copy link

commented Mar 27, 2017

@oleg-nenashev thanks, I'm definitely interested in this PR as we are slowly migrating our jobs to pipeline.

I haven't had time to look into this yet though and I'm not too familiar with pipeline-related Jenkins code in general so this might take some time.

@jglick

This comment has been minimized.

Copy link
Member Author

commented Mar 30, 2017

Well for this to work with Pipeline

  • a series of PRs associated with JENKINS-38381 need to be merged & released; currently stalled pending tests on performance impacts
  • this patch, and perhaps this whole plugin, would need to be made more product-quality—I consider this a proof of concept, not optimized in the least
@paulwilljones

This comment has been minimized.

Copy link

commented on 5888222 Apr 17, 2017

I am struggling to build this branch (with mvn package) or imitate the demo with a similarly configured Jenkins container. What's the easiest way of getting a build of the plugin such that pipeline output to ES is supported?

@jglick jglick removed their assignment May 2, 2017

@jglick

This comment has been minimized.

Copy link
Member Author

commented May 2, 2017

imitate the demo with a similarly configured Jenkins container

Do the instructions in demo/README.md not work as advertised?

@paulwilljones

This comment has been minimized.

Copy link

commented May 3, 2017

The demo works, however using the plugin with ELK 5.X yields an error when making a get request for the logs from ES due to the request fields changing between versions.

Is there any incentive to support this plugin / functionality?

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented May 3, 2017

@paulwilljones Do you mean compatibility of this PR with Elasticsearch 5? If somebody finds time to finalize these changes, I think it will definitely be in the TODO list.

@jglick

This comment has been minimized.

Copy link
Member Author

commented May 3, 2017

@paulwilljones to set expectations, I know next to nothing about ELK and care little about this particular plugin (certainly the code added here is not even close to production quality). I filed this as a proof of concept to demonstrate that systems developed in the upstream PRs can really work “end-to-end”; could just as well have connected to any other service which allows character/byte streams to be incrementally uploaded and downloaded, but this plugin happened to be handy.

jglick added 2 commits Feb 6, 2018
@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Apr 2, 2018

BTW the renewed demo has been also packaged as WAR in https://github.com/jenkinsci/custom-war-packager/tree/master/demo/external-logging-elasticsearch (as a demo for Custom WAR Packager). I doubt this PR is going to be integrated in such way anyway tho. A clean implementation in a separate plugin may be preferable, especially for log browsing

@oleg-nenashev oleg-nenashev removed their request for review Apr 2, 2018

jglick added 3 commits Jun 11, 2018
@jglick

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2018

This is now out of date not just with respect to master but with major refactorings in the upstream PRs, so it is pretty much useless. If we want an ELK-based implementation it will be easier to write one from scratch at this point. (Which would be better anyway, as it would not pick up unrelated and unwanted historical features from this plugin.)

@jglick jglick closed this Jun 21, 2018

@oleg-nenashev oleg-nenashev referenced this pull request Jul 12, 2018
0 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.