Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-44665] - "Select all" button inverts all permissions in the Matrix Auth Security settings #17

Merged
merged 2 commits into from Jun 28, 2017

Conversation

@ksenia-nenasheva
Copy link
Contributor

ksenia-nenasheva commented Jun 11, 2017

See JENKINS-44665.

Details:
The old button did inversion for all permissions in the Matrix Auth Security settings:
2017-06-11 19 58 40

  • Delete old button
  • Add new "Select all" and "Unselect all" buttons with new icons.

2017-06-11 13 21 11

…n the Matrix Auth Security settings
@ksenia-nenasheva

This comment has been minimized.

Copy link
Contributor Author

ksenia-nenasheva commented Jun 26, 2017

@daniel-beck

This comment has been minimized.

Copy link
Member

daniel-beck commented Jun 26, 2017

Why add both png and gif?

@ksenia-nenasheva

This comment has been minimized.

Copy link
Contributor Author

ksenia-nenasheva commented Jun 26, 2017

@daniel-beck Done.
While my PR has been merged, PR jenkinsci/jenkins#1602 can be closed (issue #26544)

@jglick
jglick approved these changes Jun 28, 2017
e.onclick = function() {
var tr = findAncestor(this,"TR");
var inputs = tr.getElementsByTagName("INPUT");
for(var i=0; i<inputs.length; i++){

This comment has been minimized.

Copy link
@jglick

jglick Jun 28, 2017

Member

Would be nice to share the common code in a separate function.

@jglick jglick merged commit 64764c1 into jenkinsci:master Jun 28, 2017
1 check passed
1 check passed
Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.