[JENKINS-44444] Matrix-project is failing the PCT #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By conditionally use a xml file that does not fire the OldDataMonitor on cores >= 1.653
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
oleg-nenashev
requested changes
May 23, 2017
There was a problem hiding this comment.
My impression is that it actually suppresses bug in the Jenkins core, hence it is probably a valid PCT failure. https://github.com/jenkinsci/jenkins/pull/2114/files should have probably had the migration logic in readResolve(). CC @jglick
Not a bug, but it needs a discussion.
|
@oleg-nenashev Thanks! I will let you guys discuss the issue then |
|
Reproduced, looking into it. |
jglick
suggested changes
May 23, 2017
|
Clossing this as superseded by #50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-44444
Make the test compatible with core >=1.653
By conditionally use a xml file that does not fire the OldDataMonitor on cores 1.653+
@reviewbybees