Skip to content
Permalink
Browse files
[JENKINS-19801 JENKINS-19884] Bump core version to 1.538
  • Loading branch information
olivergondza committed Nov 2, 2013
1 parent efe84b3 commit e01eb60574c45b6c16091bfd91a05aa36071df68
Showing with 1 addition and 1 deletion.
  1. +1 −1 pom.xml
@@ -29,7 +29,7 @@ THE SOFTWARE.
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>1.532</version>
<version>1.538</version>
</parent>

<groupId>org.jenkins-ci.main</groupId><!-- for historical reason, this plugin has a different groupId -->

6 comments on commit e01eb60

@jglick
Copy link
Member

@jglick jglick commented on e01eb60 Nov 13, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make new updates of the plugin unusable on the forthcoming LTS. Is it really necessary?

@olivergondza
Copy link
Member Author

@olivergondza olivergondza commented on e01eb60 Nov 13, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can revert (this commit and) the fixes not to bump the the dependency so users will have maven-plugin updates in LTS, but I would like to avoid that. We can always deliver critical fixes in maven-plugin 2.0.1. Trying to stay compatible with LTS base release can make contributing more tedious. Especially for maven plugin where lots of changes span across core and plugin.

@jglick
Copy link
Member

@jglick jglick commented on e01eb60 Nov 13, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we can always do a 2.0.1 with cherry-picked fixes, it is just a bit tedious, so it is less likely to happen, and fewer available fixes would likely be included if it did.

Perhaps actively developed plugins (I do not think this is at all specific to maven-plugin) would keep multiple branches, but to avoid confusion no master: one for each existing LTS line, e.g. lts-1.509 and lts-1.532, and one post-lts. When committing a change or submitting a PR you would pick the earliest branch whose baseline core version could accommodate your change. And the plugin maintainer would need to periodically (or at least before releases) merge earlier branches into later branches, closing branches once the corresponding LTS line goes dead. Then no cherry picking is ever needed. Unfortunately maven-release-plugin is not really aware of this kind of version scheme—unless you use a different major version for each branch, which gives the (generally) false impression that incompatible changes are involved.

@jglick
Copy link
Member

@jglick jglick commented on e01eb60 Dec 31, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cf. JENKINS-20209, fix not available in LTS.

@olivergondza
Copy link
Member Author

@olivergondza olivergondza commented on e01eb60 Jan 3, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jglick: https://github.com/jenkinsci/maven-plugin/tree/lts-1.532

I will release this tomorow as 2.0.1 unless you have any objections. It is master without the couple of commits that required version bump.

@jglick
Copy link
Member

@jglick jglick commented on e01eb60 Jan 3, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks.

Please sign in to comment.