Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-42549, JENKINS-40621] - Update the Maven Embedder Lib to 3.12.1 #100

Merged
merged 1 commit into from Jul 10, 2017

Conversation

@oleg-nenashev
Copy link
Member

commented Jul 6, 2017

  • JENKINS-40621 - Prevent leaked file descriptors when invoking MavenEmbedderUtils#getMavenVersion()(PR #5)
  • JENKINS-42549 - Prevent file access errors in JARUrlConnection due to the parallel reading of JAR resources in MavenEmbedderUtils#getMavenVersion() (regression in 3.12)

Full diff: jenkinsci/lib-jenkins-maven-embedder@lib-jenkins-maven-embedder-3.12...lib-jenkins-maven-embedder-3.12.1

Changelog: https://github.com/jenkinsci/lib-jenkins-maven-embedder/blob/master/CHANGELOG.md#3121

@reviewbybees @aheritier @olamy @abayer

@reviewbybees

This comment has been minimized.

Copy link

commented Jul 6, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@oleg-nenashev

This comment has been minimized.

Copy link
Member Author

commented Jul 6, 2017

Cause of the PR builder failure "1 error: Type org.eclipse.tycho.core.p2.P2ArtifactRepositoryLayout not present: org/eclipse/tycho/core/p2/P2ArtifactRepositoryLayout : Unsupported major.minor version 52.0".

It is unlikely caused by my change, maybe infra. CC @aheritier @rtyler

@abayer
abayer approved these changes Jul 6, 2017
@oleg-nenashev

This comment has been minimized.

Copy link
Member Author

commented Jul 6, 2017

@jglick
jglick approved these changes Jul 6, 2017
@jglick

This comment has been minimized.

Copy link
Member

commented Jul 6, 2017

Build failure is from 9f2f53a, which I guess should have been done via PR.

@aheritier

This comment has been minimized.

Copy link
Member

commented Jul 6, 2017

@aheritier aheritier closed this Jul 7, 2017
@aheritier aheritier reopened this Jul 7, 2017
@aheritier

This comment has been minimized.

Copy link
Member

commented Jul 7, 2017

I cannot retrigger a build (sadpanda)

@oleg-nenashev

This comment has been minimized.

Copy link
Member Author

commented Jul 7, 2017

@aheritier With the Multi-branch plugin you have to wait for a while. A couple of muinutes

@oleg-nenashev oleg-nenashev reopened this Jul 7, 2017
@oleg-nenashev

This comment has been minimized.

Copy link
Member Author

commented Jul 7, 2017

wat, it does not trigger

@aheritier

This comment has been minimized.

Copy link
Member

commented Jul 7, 2017

nope

@aheritier aheritier merged commit c068c94 into master Jul 10, 2017
1 check failed
1 check failed
continuous-integration/jenkins/branch The build of this commit was aborted
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.