Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-22252] Revert JENKINS-26947 fix #52

Merged
merged 1 commit into from Oct 1, 2015

Conversation

Projects
None yet
6 participants
@jglick
Copy link
Member

commented Sep 30, 2015

JENKINS-22252

Reverts #39 because that caused a critical regression: basically anyone running a recent version of Maven and one of the analysis publishers would see build failures after updating the plugin to 2.12. (BTW whoever released 2.12—it is not attributed; @ndeloof?—neglected to update the changelog in the wiki.)

Verified using jenkinsci/acceptance-test-harness#41.

@reviewbybees esp. @ydubreuil whose change needs to be reworked. I propose cutting a new release promptly with this reversion, reopening JENKINS-26947, and then the problem can be studied and tested better and potentially refixed in a later release. @oleg-nenashev might be able to help.

Revert "[FIX JENKINS-26947] forcibly terminate Maven remoting channel…
… when upstream channel get closed"

[FIXED JENKINS-22252] Caused a regression.
This reverts commit 47b2873.
@reviewbybees

This comment has been minimized.

Copy link

commented Sep 30, 2015

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@KostyaSha

This comment has been minimized.

Copy link
Member

commented Sep 30, 2015

👍

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Oct 1, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Oct 1, 2015

👍 and 🐝

@ydubreuil

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2015

🐝 Will work with @oleg-nenashev to provide a better fix.

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Oct 1, 2015

@reviewbybees

This comment has been minimized.

Copy link

commented Oct 1, 2015

This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging.

jglick added a commit that referenced this pull request Oct 1, 2015

Merge pull request #52 from jglick/IllegalAccessError-JENKINS-22252
[JENKINS-22252] Revert JENKINS-26947 fix

@jglick jglick merged commit e85502a into jenkinsci:master Oct 1, 2015

1 check passed

Jenkins This pull request looks good
Details

@jglick jglick deleted the jglick:IllegalAccessError-JENKINS-22252 branch Oct 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.