Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-42833] fix typo in image source #98

Merged
merged 1 commit into from Jun 2, 2017

Conversation

@rpionke
Copy link
Member

rpionke commented May 4, 2017

@stephenc introduced a small typo which leads to the following behaviour:
image

@aheritier aheritier requested review from stephenc and aheritier May 4, 2017
@aheritier

This comment has been minimized.

Copy link
Member

aheritier commented May 4, 2017

thanks a lot @rpionke
I will test it but I agree it seems to be a simple type (just not sure why he missed it)

@amuniz

This comment has been minimized.

Copy link
Member

amuniz commented May 4, 2017

👍 I'm currently observing this issue in a local instance

@amuniz

This comment has been minimized.

Copy link
Member

amuniz commented May 4, 2017

Given the coolness of the new image... I'd say it is worth a new release only for it! :)

@rpionke

This comment has been minimized.

Copy link
Member Author

rpionke commented May 4, 2017

Thats true 😄

@aheritier

This comment has been minimized.

Copy link
Member

aheritier commented May 4, 2017

@amuniz for sure I will integrate this one shortly but I need also to fix this regression in 2.15 : https://issues.jenkins-ci.org/browse/JENKINS-42549

@aheritier aheritier merged commit a8b6be6 into jenkinsci:master Jun 2, 2017
1 check passed
1 check passed
Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.