Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#JENKINS-13400 #24

Closed
wants to merge 6 commits into from

Conversation

@cactusman

This comment has been minimized.

Copy link
Member Author

commented Apr 14, 2012

I didn't change MultiSCMChangeLogParser.java and MultiSCMChangeLogSet.java.
That was changed for merge.

@buildhive

This comment has been minimized.

Copy link

commented Apr 26, 2012

Jenkins » mercurial-plugin #4 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@jglick

This comment has been minimized.

Copy link
Member

commented Apr 30, 2012

By the way do not worry about the BuildHive failures - a job misconfiguration.

@@ -1,131 +1,131 @@

This comment has been minimized.

Copy link
@jglick

jglick Apr 30, 2012

Member

Do not want this diff in the pull request.

@@ -1,125 +1,125 @@

This comment has been minimized.

Copy link
@jglick

jglick Apr 30, 2012

Member

Or this.

@@ -4,7 +4,7 @@
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>1.400</version>
<version>1.421</version>

This comment has been minimized.

Copy link
@jglick

jglick Apr 30, 2012

Member

Is this really necessary? BTW does not merge with trunk.

return true;
}

listener.error(

This comment has been minimized.

Copy link
@jglick

jglick Apr 30, 2012

Member

Avoid gratuitous whitespace changes.

// #JENKINS-13400
// source 'file://' is 7 chars.
if (new File(upstream).toURI().toString().equals(source) ||
source.substring(7).equals(upstream)) {

This comment has been minimized.

Copy link
@jglick

jglick Apr 30, 2012

Member

A bit fragile. I will try to solve the reported bug differently.

@jglick

This comment has been minimized.

Copy link
Member

commented Apr 30, 2012

Will not apply in current form.

@jglick jglick closed this Apr 30, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.