Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Rhodecode server (rhodecode.org) #4

Merged
merged 2 commits into from Oct 15, 2011

Conversation

Projects
None yet
4 participants
@marcsanfacon
Copy link
Contributor

commented Sep 16, 2011

I added support for Rhodecode server in the mercurial plugin.

I'm not a Java expert, so let me know if I forgot something.

I am running it on my side and everything works fine.

Thanks

@mfriedenhagen

This comment has been minimized.

Copy link
Member

commented Sep 16, 2011

I do not see a test for the browser, the other ones have one.

@marc-guenther

This comment has been minimized.

Copy link
Member

commented Sep 26, 2011

Oops, I just did the same thing last week :) Perfect timing...

A question about the generated diff URLs: On my installation of Rhodecode, the anchor's name was prefixed with "CHANGE-" followed by the dashified path. You don't seem to have this prefix?

@marcsanfacon

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2011

We are using version 1.2.0 beta and I redirected the diff link to the main changeset page that shows the diffs on the file.

Which version are you using?

@marc-guenther

This comment has been minimized.

Copy link
Member

commented Sep 27, 2011

We are using 1.1.8, same version as on the demo site. Links look like this:
http://demo.rhodecode.org/fix-it-all/changeset/eab0cf9ab8bffaf6a96eea120f008af274c76410#CHANGE-docs-api-index.rst

If I leave out the "CHANGE-" it doesn't work anymore.

So that means we have two different kinds of links in the old and new RhodeCode version? :(

@marcsanfacon

This comment has been minimized.

Copy link
Contributor Author

commented Sep 28, 2011

Looks like we're going to need 2 version of the plug-in.

Version 1.2.0 changed the URL, as can be seen here:

https://secure.rhodecode.org/rhodecode/changeset/7592484e84d3c22f78ad8a75b0129602b9ee9c87#Crhodecode-model-repo.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.