Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-28121] Need to mkdirs before clone #81

Merged
merged 2 commits into from Jul 13, 2016

Conversation

Projects
None yet
3 participants
@jglick
Copy link
Member

commented Jun 24, 2016

JENKINS-28121

Picks up tests from jenkinsci/workflow-scm-step-plugin#4 and jenkinsci/workflow-multibranch-plugin#17, and makes them pass when CACHE_LOCAL_REPOS is deleted.

@reviewbybees

[FIXED JENKINS-28121] Need to mkdirs before clone.
Failure was being masked both in automated and manual tests by the CACHE_LOCAL_REPOS optimization.
Just deleting that special case now; probably rarely useful in the field, and tends to hide behavioral differences.
@@ -13,8 +13,7 @@
<url>http://wiki.jenkins-ci.org/display/JENKINS/Mercurial+Plugin</url>

<properties>
<jenkins.version>1.580.1</jenkins.version>
<java.level>6</java.level>
<jenkins.version>1.642.3</jenkins.version>

This comment has been minimized.

Copy link
@jglick

jglick Jun 24, 2016

Author Member

Need a new baseline to be able to run tests against reasonably modern versions of Pipeline; the 1.4.x line compatible with 1.580.x did not even include workflow-multibranch, which most naturally reproduces this error.

@reviewbybees

This comment has been minimized.

Copy link

commented Jun 24, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@@ -809,6 +809,7 @@ private void clone(Run<?, ?> build, Launcher launcher, FilePath repository, Node
args.add(getSource(env));
}
args.add(repository.getRemote());
repository.mkdirs();

This comment has been minimized.

Copy link
@jglick

jglick Jun 24, 2016

Author Member

The actual fix.

@@ -932,12 +933,8 @@ private boolean causedByMissingHg(IOException e) {
return message != null && message.startsWith("Cannot run program") && message.endsWith("No such file or directory");
}

static boolean CACHE_LOCAL_REPOS = false;

This comment has been minimized.

Copy link
@abayer

abayer Jul 11, 2016

Member

So what was the point of this such that we're getting rid of it now?

This comment has been minimized.

Copy link
@jglick

jglick Jul 11, 2016

Author Member

It was a little faster. But for a situation unlikely to arise in production.

@abayer

This comment has been minimized.

Copy link
Member

commented Jul 13, 2016

🐝

@jglick jglick merged commit f9482e3 into jenkinsci:master Jul 13, 2016

1 check passed

Jenkins This pull request looks good
Details

@jglick jglick deleted the jglick:mkdirs-JENKINS-28121 branch Jul 13, 2016

@jglick jglick referenced this pull request Jul 13, 2016

Merged

Create a test JAR #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.