Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch AbortException for hg locate, add '--hidden' for certain commands and add option to include bookmarks #96

Closed
wants to merge 6 commits into from

Conversation

Projects
None yet
3 participants
@domruf
Copy link

commented Jan 31, 2017

No description provided.

catch AbortException for hg locate
When a file can not be found, 'hg locate' exits with return value 1, which cause
an Abort Exception to be thrown.
Therefore catch the exception and handle it as SCMFile.Type.NONEXISTENT.

@domruf domruf force-pushed the domruf:master branch 3 times, most recently from 268b3d1 to 26b8081 Jan 31, 2017

domruf added some commits Feb 2, 2017

add --hidden in determineChanges, heads and bundle
When using changeset evolution the last revision might be hidden, therefore use
--hidden to still get the changes.
There maybe more places that should use this. But I don't have a good overview
of the project (yet). These are the places where I had problems so far.
use branches command instead of heads to get branch revisions
Using heads is problematic because it returns not only the latest
head revision of a branch but all of them. Sadly befor version 3.5
mercurial did not support the --template for the branches command.
But on the other hand it is not that hard to use the default output.

@domruf domruf force-pushed the domruf:master branch from 26b8081 to 857f0c2 Feb 3, 2017

domruf added some commits Feb 7, 2017

handle stderr separably so it will not interfere with the output inte…
…rpretation

Otherwise error messages like 'obsolete feature not enabled but 10 markers found!'
could mess up the output interpretation.

@domruf domruf force-pushed the domruf:master branch 3 times, most recently from 6a51037 to 4e305fc Feb 8, 2017

@domruf domruf changed the title catch AbortException for hg locate and add option to include bookmarks catch AbortException for hg locate, add '--hidden' for certain commands and add option to include bookmarks Feb 9, 2017

@domruf

This comment has been minimized.

Copy link
Author

commented Feb 10, 2017

@stephenc what version of mercurial is used for these tests? What is the oldest supported version that I need to consider?

@domruf domruf force-pushed the domruf:master branch from 4e305fc to 5a202dd Feb 10, 2017

@domruf domruf force-pushed the domruf:master branch from 5a202dd to b5f19f8 Feb 21, 2017

@jglick

This comment has been minimized.

Copy link
Member

commented Apr 26, 2017

what version of mercurial is used for these tests?

Pretty much up in the air until I find time to fix up and merge #93.

@jglick
Copy link
Member

left a comment

This seems like a mixture of unrelated changes. Could you split it into more digestible PRs each solving a particular problem please? Also check JIRA to see if you are fixing something which is already filed.

@jglick

This comment has been minimized.

Copy link
Member

commented Jul 17, 2017

The first sounds related to #106.

@tlvu

This comment has been minimized.

Copy link

commented Mar 14, 2018

@domruf Using Mercurial Evolve with Jenkins here.

You should also add --hidden for hg status.

Otherwise we have this error:

ERROR: Failed to run /opt/mercurial/bin/hh status --rev bfa9618dd315285b6001ef04998ff52f963ce8c4 --rev 919545acca1af54b5dce7bffbbc04f62dae91598
abort: hidden revision 'bfa9618dd315285b6001ef04998ff52f963ce8c4'!
(use --hidden to access hidden revisions)
ERROR: polling failed in /var/jenkins_home/jobs/BC-Services/jobs/bc-protos-devel-default/workspace@script on : null

for commit hook build trigger on a single branch pipeline. Weirdly enough, multi branch pipeline commit hook build trigger works fine and simply ignore this error.

Thanks for adding Evolve support to Jenkins.

@jglick

This comment has been minimized.

Copy link
Member

commented Jan 24, 2019

Closing this as it seems abandoned, though there are likely pieces that could be resurrected.

@tlvu I have not used Mercurial in years and have no idea what Evolve is or what --hidden does. If you think you know of a code change which would fix some scenario you encounter, please file a separate PR covering just that change, with a functional test demonstrating the need for it if at all possible (I can give some pointers in a new PR upon request).

@jglick jglick closed this Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.