Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-31054] Generate button does not work #13

Merged
merged 1 commit into from Oct 21, 2015

Conversation

@recena
Copy link

commented Oct 20, 2015

@reviewbybees

This comment has been minimized.

Copy link

commented Oct 20, 2015

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@recena

This comment has been minimized.

Copy link
Author

commented Oct 20, 2015

I've done tests using Firefox and Chrome on Ubuntu. It would be nice to try it using IE.

@stephenc

This comment has been minimized.

Copy link
Member

commented Oct 20, 2015

@recena I believe it was window.event to make it work on IE (but that is hazy recollection at best)

@recena

This comment has been minimized.

Copy link
Author

commented Oct 20, 2015

@stephenc I'm going to try it using IE. I have several VMs to do this kind of tests.

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Oct 20, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@recena

This comment has been minimized.

Copy link
Author

commented Oct 20, 2015

@stephenc I did a test using IE10 on Windows 7 and works fine.

jenkins-31054

@stephenc

This comment has been minimized.

Copy link
Member

commented Oct 20, 2015

@recena probably was IE6 or 7 or 8 at the time... 🐝

@stephenc

This comment has been minimized.

Copy link
Member

commented Oct 20, 2015

Oooh I assume you tried Safari as well ;-)

@recena

This comment has been minimized.

Copy link
Author

commented Oct 21, 2015

@stephenc I'm following this guideline. Using Safari Versión 9.0 (9537.86.1.56.2) works fine.

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Oct 21, 2015

🐝 since it has been tested

@recena

This comment has been minimized.

Copy link
Author

commented Oct 21, 2015

@reviewbybees

This comment has been minimized.

Copy link

commented Oct 21, 2015

This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging.

stephenc added a commit that referenced this pull request Oct 21, 2015
[JENKINS-31054] Generate button does not work
@stephenc stephenc merged commit 297f81f into jenkinsci:master Oct 21, 2015
1 check passed
1 check passed
Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.