Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-19830] Warn about passwords in log #10

Merged
merged 1 commit into from Oct 5, 2013

Conversation

Projects
None yet
4 participants
@jglick
Copy link
Member

commented Oct 1, 2013

JENKINS-19830

Alternate fix is to replace

args.add(parameters.toString());

with

args.addMasked(parameters.toString());

but this could impair debugging. Could make it an option.

@buildhive

This comment has been minimized.

Copy link

commented Oct 1, 2013

Jenkins » msbuild-plugin #34 SUCCESS
This pull request looks good
(what's this?)

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Oct 1, 2013

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

gboissinot added a commit that referenced this pull request Oct 5, 2013

Merge pull request #10 from jglick/mask-args-JENKINS-19830
[FIXED JENKINS-19830] Warn about passwords in log

@gboissinot gboissinot merged commit f30df9d into jenkinsci:master Oct 5, 2013

@jglick jglick deleted the jglick:mask-args-JENKINS-19830 branch Oct 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.