Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move documentation from wiki to github #39

Merged
merged 3 commits into from Feb 26, 2021

Conversation

KasperHeyndrickx
Copy link
Contributor

@KasperHeyndrickx KasperHeyndrickx commented Dec 2, 2019

No description provided.

@jetersen
Copy link
Member

@jetersen jetersen commented Dec 2, 2019

link to see current commit author: https://github.com/jenkinsci/msbuild-plugin/commit/a7a4862f2feee787a4fd4a28f830ba6e332e0277.patch

@KasperHeyndrickx
You might want to set up an email alias on your GitHub account 🥇
https://help.github.com/articles/adding-an-email-address-to-your-github-account/

Or look into fixing your git user.email config 😅
https://help.github.com/articles/setting-your-commit-email-address-in-git
then you would need to amend your commits: https://stackoverflow.com/a/3042512
after changing author

to get proper credit for your commits 🏆

@KasperHeyndrickx
Copy link
Contributor Author

@KasperHeyndrickx KasperHeyndrickx commented Dec 2, 2019

@marshall777 Could you take a look at these changes?
This moves documentation from wiki to git. https://jenkins.io/blog/2019/10/21/plugin-docs-on-github/

Copy link
Member

@jetersen jetersen left a comment

LGTM

Copy link
Member

@jetersen jetersen left a comment

Some minor comments

README.md Outdated Show resolved Hide resolved
README.md Outdated
"C:\\Program Files (x86)\\Microsoft Visual
Studio\\2017\\Community\\MSBuild\\15.0\\Bin\\" If you have multiple
Copy link
Member

@jetersen jetersen Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community\\MSBuild\\15.0\\Bin\\"

Copy link
Contributor Author

@KasperHeyndrickx KasperHeyndrickx Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you're suggesting here?

Copy link
Member

@jetersen jetersen Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to suggest #39 (comment) 😅

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-Authored-By: Joseph Petersen <josephp90@gmail.com>
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

LGTM, thanks!

@MRamonLeon MRamonLeon merged commit c9bd114 into jenkinsci:master Feb 26, 2021
10 checks passed
Plugin documentation Migration (Wiki=>GitHub) automation moved this from In progress to Merged Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants