-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move documentation from wiki to github #39
Conversation
link to see current commit author: https://github.com/jenkinsci/msbuild-plugin/commit/a7a4862f2feee787a4fd4a28f830ba6e332e0277.patch @KasperHeyndrickx Or look into fixing your git user.email config 😅 to get proper credit for your commits 🏆 |
8e8358b
to
551345d
Compare
@marshall777 Could you take a look at these changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments
README.md
Outdated
"C:\\Program Files (x86)\\Microsoft Visual | ||
Studio\\2017\\Community\\MSBuild\\15.0\\Bin\\" If you have multiple |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community\\MSBuild\\15.0\\Bin\\"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you're suggesting here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to suggest #39 (comment) 😅
Co-Authored-By: Joseph Petersen <josephp90@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
No description provided.