Skip to content

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
...
  • 3 commits
  • 1 file changed
  • 1 commit comment
  • 2 contributors
Commits on Mar 07, 2011
unknown [maven-release-plugin] prepare release multiple-scms-0.1 2b5bd72
Commits on Mar 14, 2011
@kmbell kmbell Remove redundant check for missing baseline ffb0ed8
@kmbell kmbell Set version to 0.2-SNAPSHOT
Not sure if this is correct, but it is similar to what I see in
other plugins.
32b8245
Showing with 2 additions and 2 deletions.
  1. +2 −2 src/main/java/org/jenkinsci/plugins/multiplescms/MultiSCM.java
View
4 src/main/java/org/jenkinsci/plugins/multiplescms/MultiSCM.java
@@ -73,8 +73,8 @@ protected PollingResult compareRemoteRevisionWith(
Change overallChange = Change.NONE;
for(SCM scm : scms) {
- SCMRevisionState scmBaseline = baselineStates != null ? baselineStates.get(scm.getClass().getName()) : null;
- PollingResult scmResult = scm.poll(project, launcher, workspace, listener, scmBaseline != null ? scmBaseline : SCMRevisionState.NONE);
+ SCMRevisionState scmBaseline = baselineStates != null ? baselineStates.get(scm.getClass().getName()) : SCMRevisionState.NONE;
+ PollingResult scmResult = scm.poll(project, launcher, workspace, listener, scmBaseline);
currentStates.add(scm.getClass().getName(), scmResult.remote);
if(scmResult.change.compareTo(overallChange) > 0)
overallChange = scmResult.change;

Showing you all comments on commits in this comparison.

@alanharder
Jenkins member

note: these are only equivalent if baselineStates.get() is guaranteed to return non-null.. if that map may not have every scm type, the old code was actually safer..

Something went wrong with that request. Please try again.