Assorted fixes #1

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants
Member

jglick commented Oct 14, 2011

JENKINS-12298 fix.
Changelog browser fixes incl. JENKINS-11377.
Remote API client fixes.
Relative path to parent makes no sense for a standalone repo;
need to specify repo where parent resides.
Specify project encoding to avoid warning.
Tell NetBeans to use JDK 6 to build even if running on JDK 7.

Jesse Glick added some commits Oct 14, 2011

Jesse Glick Build fixes.
Relative path to parent makes no sense for a standalone repo;
need to specify repo where parent resides.
Specify project encoding to avoid warning.
Tell NetBeans to use JDK 6 to build even if running on JDK 7.
8958fa1
Jesse Glick Implement getKind() to match normal value when using a homogeneous SC…
…M set.

This allows clients (e.g. NetBeans IDE) to parse the changelog with knowledge of that SCM.
If using a heterogeneous SCM set, parsing will be hard, but at least give a more diagnostic string.
11af4d0
Member

jglick commented Oct 17, 2011

Added another fix useful for remote API clients. Not related to the first, but have not yet figured out how to start an independent pull request...

Jesse Glick added some commits Jan 4, 2012

Jesse Glick [FIXED JENKINS-12298] MultiSCMRevisionState.revisionStates cannot dif…
…ferentiate multiple instances of a single SCM type.

Use a proper key rather than Class.getName().
Makes polling work when using the Hg plugin (1.39-SNAPSHOT).
Also be more robust in case scmBaseline is null (noticed during a unit test only).
19e52ee
Jesse Glick Properly delegate to single SCM's repository browser so hyperlinks wo…
…rk (in both digest and detail pages).

[FIXED JENKINS-11377] Changes view: show which repository a changeset is from.
Does not fix JENKINS-10008 but at least lets it work in case the SCM's default browser is usable.
b785c14
Contributor

kmbell commented Jan 9, 2012

Thanks for submitting these fixes. I've tested your changes and they all look good with the exception of the repository browser commit. The approach taken seems to cause other (worse?) problems:

  • The job configuration page will no longer load because there is no config.jelly for the MultiSCMsRepositoryBrowser. It hangs with the gray 'LOADING' overlay permanently displayed. Adding an empty page fixes this problem but...
  • The repository browser is always reset to 'multi' for each SCM when the configuration is loaded, but saving the configuration in this state fails because the repository browser isn't an instance of whatever type the SCM expects it to be. As long as you reset it to 'Auto', before saving, it does appear to try to work. I'm running WebSVN and RhodeCode however, so the default links don't work for me.

I remember now why I punted on the browser configuration... The SCM plugin API doesn't provide an easy way to hook into the repository browser API like it does for say the change log parsers. I looked at it a little longer last week, but still don't have any great ideas.

Anyway, I'm also a Git/GitHub newbie, so I'm not sure how to proceed with your other three commits. Should you modify your pull request to amend or remove the repo browser commit, or should I just merge the other three and close the request and you can either open a new one if you have more ideas, or just drop it for now?

Thanks again,
Kevin

Contributor

kmbell commented Jan 11, 2012

I went ahead and merged the first three commits. You can reopen another pull request if you find a fix for the repository browser problems.

kmbell closed this Jan 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment