Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add a SCMRevisionState of type MultiSCMRevisionState #7

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@rodrigc
Copy link
Contributor

commented Feb 7, 2015

to the MultiSCMRevisionState variable associated with the overal job.

When a MultiSCM.checkout() is done, the list of SCMs is iterated
over. For each SCM in the list, we obtain the SCMRevisionState
for that SCM and pass it down to the checkout() method for each SCM.
For a Subversion checkout, the Subversion plugin
downcasts the revision revision state to SVNRevisionState.

Without this fix, a revision state of type MultiSCMRevisionState
was being passed down into the Subversion plugin. This was
causing a ClassCastException to be thrown.

[JENKINS-26303]

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Feb 8, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@pablaasmo

This comment has been minimized.

Copy link

commented Feb 10, 2015

I have test this in my setup, and it works OK.

Do not add a SCMRevisionState of type MultiSCMRevisionState
to the MultiSCMRevisionState variable associated with the overal job.

When a MultiSCM.checkout() is done, the list of SCMs is iterated
over.  For each SCM in the list, we obtain the SCMRevisionState
for that SCM and pass it down to the checkout() method for each SCM.
For a Subversion checkout, the Subversion plugin
downcasts the revision revision state to SVNRevisionState.

Without this fix, a revision state of type MultiSCMRevisionState
was being passed down into the Subversion plugin.  This was
causing a ClassCastException to be thrown.

[FIXED JENKINS-26303]
@rodrigc

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2015

Merged 1e7d7bd

@rodrigc rodrigc closed this Mar 8, 2015

@rodrigc rodrigc deleted the rodrigc:JENKINS-26303 branch Mar 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.